Refactor setup.py a bit #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embray
force-pushed
the
setup-updates
branch
from
2c45dcb
to
32a27ef
Compare
|
I should add, this was motivated originally by the desire to add more build configurations to the Travis-CI builds. I wanted to be able to use environment variables to force values of the |
|
Something not quite right here with handling of include dirs; worked for me locally for some reason. |
the build_ext command. In particular compile-time flags are not checked, and Cython is not run unless we are running the build_ext command.
embray
force-pushed
the
setup-updates
branch
from
2c9043e
to
4b5ae22
Compare
|
LGTM. |
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves several of the operations that were performed at module-level in the
setup.pyinto a subclass of the distutilsbuild_extcommand. This way, operations that are only relevant to building extension modules are only performed when actually building extension modules, rather than unconditionally.This allows certain operations like
./setup.py --nameand./setup.py --versionto work without unnecessary side-effects.One possible small regression this introduces is that if you want the Cython-generated C sources to be included in a source distribution it's now necessary to run
./setup.py build_ext sdist, rather than./setup.py sdist, though we could also make it so thatbuild_extis run automatically as a prerequisite ofsdist. That said, I'm not sure if this is really desirable in this case, since the Cython compilation depends on someDEFstatements, which in turn depend on external values.