Add additional configurations to Travis build #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the build_ext command. In particular compile-time flags are not checked, and Cython is not run unless we are running the build_ext command.
|
Looks like you caught some bugs with your new text. Would you be up for fixing those or would you like to bounce that to me? |
|
I can fix them. I'll open a separate PR for that, then I can rebase this one and see if all the builds pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #106, this adds four new configurations that are built and tested on Travis (in this case all using Python 2.7 for now):
HAVE_LONG_DOUBLE=False,HAVE_QD=False,HAVE_NUMPY=False, andHAVE_LONG_DOUBLE = HAVE_QD = False.This should cover most branches in the Cython code impacted by these compile-time variables, if not all.
As you'll see, Travis finds a few test failures in these cases.