Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between design summary and TODO in Component Implementation 2 #29

Closed
markmccrum opened this issue Aug 6, 2023 · 2 comments
Closed

Inconsistency between design summary and TODO in Component Implementation 2 #29

markmccrum opened this issue Aug 6, 2023 · 2 comments
Assignees
@LeStarch

Comments

@markmccrum
Copy link

The design summary states that the number of LED transitions is to be reported as telemetry. In the code excerpt for Led::run_handler there is a TODO suggesting that an event should be used instead.

                // TODO: Add an event to report the number of LED transitions (this->transitions)

It probably makes more sense for it to be telemetry.
@LeStarch LeStarch self-assigned this Aug 14, 2023
@LeStarch
Copy link
Contributor

Fixed by #30

@kevin-f-ortega
Copy link
Collaborator

And #33

@kevin-f-ortega kevin-f-ortega mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeStarch @kevin-f-ortega @markmccrum