You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I saw the #IFDEF LCD preprocessor directive in video.c, I got interested in adding a color palette that similarly replicates my own original experience with Sopwith, except on an amber monochrome CGA monitor.
Idea
If it's not too big of a change, I'd like to promote that color palette option from preprocessor directive to full configuration option in the menu.
Example
I roughed together a quick example of what this feature could look like, by adding a new configuration option with a new type:
(press the play button to see the colour palette change)
Questions
Would it be more in-line with the spirit of things to simply add my own preprocessor directive instead?
If added, is implementing a CONF_INT the best way to do it?
Since the configuration menu is filling up in terms of numbered options, would a submenu accessed using a letter be preferable? (Similar to how keybindings has its own submenu)
The text was updated successfully, but these errors were encountered:
No #defines, please just add it as a full feature.
Yes, CONF_INT is fine.
No, let's stick with the one menu for now - there's plenty more screen space for more options for the time being, and we can always use other keys beyond the numbers. Though I do want to be selective about the features we add.
A few thoughts:
Brainstorming on palettes: we probably also want ones for:
Let's make sure there's enough contrast to see things properly - the amber scheme in your screenshot makes it look like the two darker shades are hard to distinguish
Can you locate the palette option on the menu next to the other video options? They're loosely (at least) arranged by function.
Summary
When I saw the
#IFDEF LCD
preprocessor directive invideo.c
, I got interested in adding a color palette that similarly replicates my own original experience with Sopwith, except on an amber monochrome CGA monitor.Idea
If it's not too big of a change, I'd like to promote that color palette option from preprocessor directive to full configuration option in the menu.
Example
I roughed together a quick example of what this feature could look like, by adding a new configuration option with a new type:
(press the play button to see the colour palette change)
Questions
CONF_INT
the best way to do it?The text was updated successfully, but these errors were encountered: