Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Environments #94

Merged
merged 8 commits into from
May 26, 2018
Merged

Display Environments #94

merged 8 commits into from
May 26, 2018

Conversation

fragmuffin
Copy link
Member

Changed method of detecting environments from:

  • get_env() returning string identifier
  • display() calling function registered under that name (simply mapped in a dict)

To mapping a DisplayEnvironment class with a

  • name,
  • priority, and
  • condition

A single instance of the class is created, and disp_env.display() called of the instance.

@fragmuffin fragmuffin mentioned this pull request May 24, 2018
@fragmuffin fragmuffin merged commit 9fc1461 into master May 26, 2018
@zignig
Copy link
Member

zignig commented May 26, 2018

Tested with current version of cqparts-server , works ! (yay)

@fragmuffin fragmuffin deleted the feature/custom-displays branch June 8, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants