Auto will-change
#2700
Merged
Auto will-change
#2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgperry
commented
Jun 14, 2024
| * | ||
| * @public | ||
| */ | ||
| transformPagePoint?: TransformPoint |
mattgperry
commented
Jun 14, 2024
| * | ||
| * @public | ||
| */ | ||
| allowTransformNone?: boolean |
mattgperry
force-pushed
the
feature/auto-will-change
branch
from
eb8c429
to
a1ed627
Compare
mattgperry
commented
Jul 3, 2024
| @@ -372,6 +360,9 @@ export class AcceleratedAnimation< | |||
| ) | |||
| } | |||
|
|
|||
| const { onStop } = this.options | |||
There was a problem hiding this comment.
This wasn't calling onStop callbacks previously
adamseckel
approved these changes
Jul 4, 2024
mattgperry
force-pushed
the
feature/auto-will-change
branch
from
3ff1bc2
to
b300f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translateZ(0)seems not to have the same layerizing effect as it used to. In this PR we make eachmotioncomponent manage its ownwillChangeMotionValue.Only values that can be responsible for adding to the compositor are added to
willChange.