Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte. Popover cannot be closed when link is external and routing is prevented. (With DEMO) #4267

Open
ievgennaida opened this issue Apr 22, 2024 · 0 comments

Comments

@ievgennaida
Copy link

Popover property "popoverClose" is ignored when when link/list item is used to change route anchor (external, close.

  "dependencies": {
    "framework7": "^8.3.0",
    "framework7-svelte": "^8.3.0",
    "svelte": "^4.2.0"
  },
  "devDependencies": {
    "@sveltejs/vite-plugin-svelte": "^2.4.5",
    "vite": "^4.4.9"
  }

Describe the bug

Link is confired to just change the hash of the URL. Example to add #page1 to the url route.
When configured with external and preventRouter={true} than parent popver cannot be closed.

To Reproduce

  1. Open demo.
  2. Click button to open popover.
  3. Click link to close popover.
  4. See that hash is applied on link click.
  5. See that popover remains.

Expected behavior

Popover should be closed when popoverClose is added to the link tags.

Actual Behavior

Popover remains opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant