Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_all_day not seems to work #111

Open
jflefebvre06 opened this issue Nov 23, 2023 · 2 comments
Open

include_all_day not seems to work #111

jflefebvre06 opened this issue Nov 23, 2023 · 2 comments

Comments

@jflefebvre06
Copy link

Hello,

I try to integrate with the following config (french School vacation)

ics_calendar:
  calendars:
    - name: "Vacances scolaires 2"
      url: "https://fr.ftp.opendatasoft.com/openscol/fr-en-calendrier-scolaire/Zone-B.ics"
      include_all_day: True

image

All day not seems to work

@jstuhlsatz
Copy link

jstuhlsatz commented Dec 5, 2023

I notice this issue with multi-day all-day events. I'm pulling ICS calendars from two different O365 instances. Neither seem to respect the default include_all_day behavior as it relates to multi-day all-day events and the events are included on the calendar.

I was able to remove the multi-day all-day events by changing the parser to ics, but that created an offset issue that I fixed with offset_hours, However, this will need to be managed w/ daylight savings.

This event was not included with the default RIE parser.
BEGIN:VEVENT
UID:
SUMMARY:DND Day
DTSTART;VALUE=DATE:20230703
DTEND;VALUE=DATE:20230704
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20231205T221637Z
TRANSP:OPAQUE
STATUS:CONFIRMED
SEQUENCE:0
LOCATION:
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:WORKINGELSEWHERE
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:TRUE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:0
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MICROSOFT-REQUESTEDATTENDANCEMODE:DEFAULT
END:VEVENT

This event remains on the calendar using the RIE parser.
BEGIN:VEVENT
UID:
SUMMARY:SPIRIT - Remote Revisit
DTSTART;VALUE=DATE:20231204
DTEND;VALUE=DATE:20231209
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20231205T221637Z
TRANSP:TRANSPARENT
STATUS:CONFIRMED
SEQUENCE:0
LOCATION:
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:FREE
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:TRUE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:0
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MICROSOFT-REQUESTEDATTENDANCEMODE:DEFAULT
END:VEVENT

Is there anything else I can provide to help diagnose this? Or is there another workaround I may be missing?

@franc6
Copy link
Owner

franc6 commented Dec 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants