Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible that this could cause Ghostty to hang on long running processes? #148

Open
blacktop opened this issue Jul 3, 2024 · 11 comments
Open

Is it possible that this could cause Ghostty to hang on long running processes? #148

blacktop opened this issue Jul 3, 2024 · 11 comments

Comments

@blacktop
Copy link

blacktop commented Jul 3, 2024

Please see ghostty-org/ghostty#1917
@franciscolourenco
Copy link
Owner

That repository doesn't seem to be available. Maybe it is private?

@blacktop
Copy link
Author

blacktop commented Jul 3, 2024

Ah yes it is, I apologize. https://mitchellh.com/ghostty @mitchellh might be able to add you if you want. It's his awesome NEW terminal. With done installed fish hangs after running tree .

@mitchellh
Copy link

Hello! I'd be happy to add you @franciscolourenco but I consider any functionality that works in other terminals and not mine a bug with my own terminal 😄 So I don't think this is a done bug. I'll invite you anyways though!

@franciscolourenco
Copy link
Owner

Thank you @mitchellh, that makes sense :)

@mitchellh
Copy link

Sorry @franciscolourenco you can't see our issue but I've tracked this down to an upstream issue: julienXX/terminal-notifier#301 Specifically from my thread:

Okay I've installed done with fish and I can reproduce this only with terminal-notifier installed. I can actually reproduce this purely with terminal-notifier:

# This hangs!
$ echo "hello" | terminal-notifier -title "Hello" -sender "com.mitchellh.ghostty"

It looks like terminal-notifier itself is hanging for some reason.

I'm not sure why it hangs with the Ghostty ID. But it appears based on the previous issue this isn't unique. I don't see any smoking guns in logs anywhere.

@mitchellh
Copy link

Btw, I was surprised to see that done doesn't use OSC9 or OSC777 (native terminal desktop notifications) supported by Kitty, WezTerm, foot, and iTerm2. Ghostty also supports these. That would make done not require any dependencies and it wouldn't have to shell out either.

Their usage:

OSC 9

OSC 9 ; <body> ST

OSC 777

OSC 777 ; notify ; <title> ; <body> ST

@peter-cardenas-ai
Copy link

@mitchellh unfortunately this doesn't work when the process is in a detached tmux session or the shell is otherwise not interactive

@mitchellh
Copy link

mitchellh commented Jul 8, 2024 •
edited
Loading

@mitchellh unfortunately this doesn't work when the process is in a detached tmux session or the shell is otherwise not interactive

True! But if the shell is interactive and it's not tmux, it does work, which I feel would still be pretty common?

@blacktop
Copy link
Author

ping

@blacktop
Copy link
Author

I'd say if you were thinking about implementing @mitchellh ideas we could keep this open @franciscolourenco otherwise I think we can close it.

@franciscolourenco
Copy link
Owner

@blacktop will have to follow up on OSC 9 and OSC 777 in a different thread. I'll leave this open for now just for reference. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mitchellh @franciscolourenco @blacktop @peter-cardenas-ai