-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure zooming out doesn't happen #176
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d7bf709:
|
Thanks for the PR @paazca, I'll review it in the next few days! |
@francoischalifour When can you review this? I tried it and it fixed the issue for me. |
@paazca Any chance you also add a test for this? |
I've been running into this as well; fix looks solid (same as what I did locally). |
Any chance of this getting merged? |
🎉 This fix was released in v1.0.7. |
Thanks @francoischalifour & @paazca 🙏 😄 🙏 |
Attempt at fixing #177
In some cases, pressing an image makes it zoom out.
Gif of the issue:
With these proposed changes, images will only zoom out if they're bigger than the viewport.