fix: use currentSrc for imgs in <picture> tags #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a490d0b:
|
francoischalifour
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
That's great! Thank you for the tests and stories as well @fennifith.
|
Closes #174. |
|
🎉 This was released in v1.0.8. |
|
Awesome - thank you! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #174 details a lack of support for differences in the selected image within a
<picture>tag. In this case, the image'scurrentSrcreflects which of the available sources the browser decided to use.In my case, the
<img>tags lack any src whatsoever, so when used outside of the<picture>tags they will not display any image.Result
I took a slightly more naive solution than what is described in #174 - any
<img>tag in a<picture>structure now setszoomed.src = original.currentSrcafter cloning the element. This ensures that the zoomed image will reflect the same source as what was originally displayed in the<picture>tag, and eliminates any flicker in the transition when used withdata-zoom-src.