Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for overflow when scrollbars are visible. #78

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented Oct 15, 2018

Closes #75.

Summary

Fixes issue where scrollbars are visible but not accounted for in the measured width.

Result

Changes as suggested.

NB - I'm not convinced this works correctly for vertical positioning on iOS Safari. But I'm also not convinced the existing solution works there either.

@francoischalifour francoischalifour self-requested a review October 15, 2018 12:07
Copy link
Owner

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@francoischalifour francoischalifour merged commit 9a06f9b into francoischalifour:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants