Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] eslint-plugin-tailwindcss + html + typescript #165

Closed
Shuunen opened this issue Sep 10, 2022 · 6 comments
Closed

[QUESTION] eslint-plugin-tailwindcss + html + typescript #165

Shuunen opened this issue Sep 10, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Shuunen
Copy link

Shuunen commented Sep 10, 2022

Hello I'm wondering the best way to setup this plugin in a simple js/ts + html project

Here is how I managed to do it :

https://github.com/Shuunen/issues/tree/eslint-plugin-tailwindcss-with-html-and-ts

Step 1 : Javascript only ✅

image

Step 2 : Adding HTML support 🟢

image

Step 3 : Adding TypeScript support 🟢

image

Step 4 : Adding an eslint rule 🔴

image

Step 5 : Moving rule & parse to another override 🟢

image

Environment

  • OS: Windows 10 x64
  • Softwares + version used:
    • VSCode 1.71
    • Node 16

What do you think ?

Is there any way to simplify this ?

Regards
@Shuunen Shuunen added the bug Something isn't working label Sep 10, 2022
@francoismassart
Copy link
Owner

Hi @Shuunen,
thank you for your exhaustive message, I'll take a look to see if it would be possible to add this to the recommended settings.

@francoismassart
Copy link
Owner

It works. I’ll update the recommended settings soon. Thanks 🙏🏻

@francoismassart francoismassart mentioned this issue Jan 23, 2023
Closed
@francoismassart
Copy link
Owner

I added few default parsers based on file extensions inside the recommended preset of v3.8.1

It should reduce the required configuration 😉

@Shuunen
Copy link
Author

Shuunen commented Jan 23, 2023

Great I'll let you know how it's going with this new release

Thanks François 👍

renovate bot referenced this issue in ziyadedher/ziyadedher Jan 23, 2023
@renovate
Update dependency eslint-plugin-tailwindcss to v3.8.1 (#821)
0d9b840 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss)
| [`3.8.0` ->
`3.8.1`](https://renovatebot.com/diffs/npm/eslint-plugin-tailwindcss/3.8.0/3.8.1)
|
[![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/compatibility-slim/3.8.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/confidence-slim/3.8.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>francoismassart/eslint-plugin-tailwindcss</summary>

###
[`v3.8.1`](https://github.com/francoismassart/eslint-plugin-tailwindcss/releases/tag/v3.8.1)

[Compare
Source](https://github.com/francoismassart/eslint-plugin-tailwindcss/compare/v3.8.0...v3.8.1)

FIX:

- reduces the minimum required configuration steps by including default
parsers per file extension in the `recommended` preset (see
[https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/165](https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/165))
- rewrite the [install instructions on the
README](https://github.com/francoismassart/eslint-plugin-tailwindcss#installation)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@francoismassart
Copy link
Owner

@Shuunen, it looks like this change is not wise because it creates more issues than it solves, see my comment
👉 #203 (comment)

I'm gonna revert it but update the documentation 😅

@Shuunen
Copy link
Author

Shuunen commented Jan 24, 2023

@francoismassart I'm not sure about that, let's talk about this in the other issue

ziyadedher referenced this issue in ziyadedher/ziyadedher Dec 16, 2023
@renovate
Update dependency eslint-plugin-tailwindcss to v3.8.1 (#821)
9d3a1b5 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss)
| [`3.8.0` ->
`3.8.1`](https://renovatebot.com/diffs/npm/eslint-plugin-tailwindcss/3.8.0/3.8.1)
|
[![age](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/compatibility-slim/3.8.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/eslint-plugin-tailwindcss/3.8.1/confidence-slim/3.8.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>francoismassart/eslint-plugin-tailwindcss</summary>

###
[`v3.8.1`](https://github.com/francoismassart/eslint-plugin-tailwindcss/releases/tag/v3.8.1)

[Compare
Source](https://github.com/francoismassart/eslint-plugin-tailwindcss/compare/v3.8.0...v3.8.1)

FIX:

- reduces the minimum required configuration steps by including default
parsers per file extension in the `recommended` preset (see
[https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/165](https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/165))
- rewrite the [install instructions on the
README](https://github.com/francoismassart/eslint-plugin-tailwindcss#installation)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shuunen @francoismassart