command and which can't be trusted when checking for gem binaries.

[lucasmazza]

We're using command and which (older versions of the script) to check if Bundler is present, but these tricks to see if the bundle cli is present can't be trusted, thanks to Rbenv shims.

gem uninstall bundler
command -v bundle 
# /opt/boxen/rbenv/shims/bundle
bundle -v
# rbenv: bundle: command not found
# 
# The `bundle' command exists in these Ruby versions:
#   1.9.3-p194
#   1.9.3-p392
#   2.0.0-p0

I guess we need to try the good old bundle -v to check Bundler's presence here.

/cc @rondy, the one who found this issue.

[rafaelfranca]

What is the status of command -v bundle? It should not be 0

[rafaelfranca]

oops, status of bundle

[rmascarenhas]

That's sad, since it leads to kinda "false" bash completion. The binary is in the PATH, though not accessible.

Since that's the case, maybe a slightly better option would be relying on the exit status of rbenv which, so that we do not have to load bundler to check if it's available.

[rafaelfranca]

Yes, 👍 for rbenv whish. I think I already did this in some project.

[lucasmazza]

👍