Skip to content

Commit

Permalink
ASoC: SOF: ipc4-topology: Add definition for generic switch/enum control
Browse files Browse the repository at this point in the history
commit 060a07c upstream.

Currently IPC4 has no notion of a switch or enum type of control which is
a generic concept in ALSA.

The generic support for these control types will be as follows:
- large config is used to send the channel-value par array
- param_id of a SWITCH type is 200
- param_id of an ENUM type is 201

Each module need to support a switch or/and enum must handle these
universal param_ids.
The message payload is described by struct sof_ipc4_control_msg_payload.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230919103115.30783-2-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
ujfalusi authored and gregkh committed Nov 8, 2024
1 parent d54afae commit f01d8fc
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion sound/soc/sof/ipc4-topology.h
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ struct sof_ipc4_copier {
/**
* struct sof_ipc4_ctrl_value_chan: generic channel mapped value data
* @channel: Channel ID
* @value: gain value
* @value: Value associated with @channel
*/
struct sof_ipc4_ctrl_value_chan {
u32 channel;
Expand All @@ -343,6 +343,23 @@ struct sof_ipc4_control_data {
};
};

#define SOF_IPC4_SWITCH_CONTROL_PARAM_ID 200
#define SOF_IPC4_ENUM_CONTROL_PARAM_ID 201

/**
* struct sof_ipc4_control_msg_payload - IPC payload for kcontrol parameters
* @id: unique id of the control
* @num_elems: Number of elements in the chanv array
* @reserved: reserved for future use, must be set to 0
* @chanv: channel ID and value array
*/
struct sof_ipc4_control_msg_payload {
uint16_t id;
uint16_t num_elems;
uint32_t reserved[4];
DECLARE_FLEX_ARRAY(struct sof_ipc4_ctrl_value_chan, chanv);
} __packed;

/**
* struct sof_ipc4_gain_params - IPC gain parameters
* @channels: Channels
Expand Down

0 comments on commit f01d8fc

Please sign in to comment.