Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS compatibility version #124

Open
raccoonmonk opened this issue Sep 18, 2018 · 1 comment
Open

macOS compatibility version #124

raccoonmonk opened this issue Sep 18, 2018 · 1 comment

Comments

@raccoonmonk
Copy link

Building the project under macOS I get the following .dylib

macxs-MacBook-Pro:src macx$ otool -L libqt5keychain.dylib 
libqt5keychain.dylib:
	../third-party/out/lib/libqt5keychain.0.8.0.dylib (compatibility version 1.0.0, current version 0.8.0)
	@rpath/QtCore.framework/Versions/5/QtCore (compatibility version 5.9.0, current version 5.9.5)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1452.23.0)
	/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 58286.51.6)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4)

compatibility version 1.0.0, current version 0.8.0

current < compatibility - this doesn't seem right.

macOS 10.13 Xcode 9.3 qtkeychain 0.8.0
Build parameters:

BUILD_DIR=build_qtkeychain
PROJ_DIR=qtkeychain
...
eval "cmake -G "$GENERATOR" -H$PROJ_DIR -B$BUILD_DIR -DCMAKE_INSTALL_PREFIX=${PREFIX} -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=${DESTDIR} -DBUILD_TRANSLATIONS=OFF"

I think the issue is in CMakeLists file

set(QTKEYCHAIN_VERSION 0.8.0)
set(QTKEYCHAIN_SOVERSION 1)
@frankosterfeld
Copy link
Owner

Oups, indeed. That's hard to fix though without possibly creating issues for using code... The way out here is to release a 1.0.0 I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants