Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: using file org.kde.KWallet.xml from kwallet package ? #172

Open
yopito opened this issue Nov 18, 2020 · 3 comments
Open

Question: using file org.kde.KWallet.xml from kwallet package ? #172

yopito opened this issue Nov 18, 2020 · 3 comments

Comments

@yopito
Copy link

yopito commented Nov 18, 2020

hello,

following issue #150 : file org.kde.KWallet.xml is out-of-date.
Since it's probably an ancient copy of the one from kwallet, does it make sense to use the one from kwallet package to build qtkeychain ?
(kwallet provides /usr/share/dbus-1/interfaces/kf5_org.kde.KWallet.xml on my system).

Test: building qtkeychain with that file from kwallet is fine here.

I've compared the two files, and apart from `s,com.trolltech.,org.qtproject.,' there are only additional entries with the one from kwallet: (diff here: https://gist.github.com/yopito/7d02d8be0574d6c11bfb6e745e1e9ea3)

@frankosterfeld
Copy link
Owner

Which package is this from, in your distro? One would have to add a config check i guess, and maybe still have a version inside the repo as fallback (it could be updated though), I guess. My only fear is that depending on the system qtkeychain was built on, behavior might slightly change or even fail on older target systems, when deploying an application with qtkeychain built in. (instead of relying on a qtkeychain package from the distribution). But then, using a vastly outdated interface could lead to the same kind of issues. So...

@yopito
Copy link
Author

yopito commented Dec 14, 2020

kwallet 5.75 (as stated in gist diff).
In the meantime, I've pushed the use of org.kde.KWallet.xml from kwallet in qtkeychain's package in VoidLinux (see [1])
So far, It working fine via nextcloud client.

[1] qtkeychain source packaging in VoidLinux: https://github.com/void-linux/void-packages/tree/master/srcpkgs/qtkeychain-qt5

@LorenDB
Copy link

LorenDB commented Nov 29, 2022

@frankosterfeld this can be closed, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants