Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-std-ify hpke-rs-rust-crypto #48

Merged
merged 5 commits into from
Nov 26, 2023
Merged

no-std-ify hpke-rs-rust-crypto #48

merged 5 commits into from
Nov 26, 2023

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 24, 2023

this removes most libstd dependencies. see commit messages for details

@japaric
rm RwLock
c522650 
there does not seem to be a need for interior mutability

the HpkeRustCrypto is already Send and Sync (provided that the
deterministic-prng feature is disabled) so RwLock is not adding much
value
@japaric
use core::fmt instead of std::fmt
5c788a1
@japaric
switch from rand to rand_core
c3b34f8 
the traits / types used here are rand_core re-exports
@japaric
disable unused (default) features in dependencies
15e1763 
some of these default feature sets pull a dependency on libstd
franziskuskiefer
franziskuskiefer approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@franziskuskiefer franziskuskiefer merged commit 3e7e671 into cryspen:main Nov 26, 2023
13 of 14 checks passed
@japaric japaric deleted the rust-crypto-no-std branch November 27, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japaric @franziskuskiefer