Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm RwLock from Hpke and no-std-ify the hpke-rs library #55

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 27, 2023

implements #52

this adds an opt-out Cargo feature named "std" and changes the signature of Hpke's methods; thus it's a semver breaking change.

this PR is best reviewed on a commit by commit basis

due to #54 I'm unable to test running this on a no-std target like the thumbv7em-none-eabihf but AFAICT no other dependency is pulling in libstd

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@franziskuskiefer franziskuskiefer merged commit 1d9baa4 into cryspen:main Nov 29, 2023
13 of 14 checks passed
@japaric japaric deleted the rm-rwlock branch November 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants