Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding child table payment Details #130 #133

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

maniamartial
Copy link
Contributor

Created a child table "payment details".
Also created a field total amount which gets the sum of amount before save
Issue #130

Copy link
Collaborator

@harshtandiya harshtandiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try creating a table field in Cases and link it to Payment Details

@maniamartial
Copy link
Contributor Author

Changes done

@NagariaHussain NagariaHussain merged commit d3da251 into frappe:develop Oct 17, 2023
0 of 2 checks passed
maniamartial added a commit to maniamartial/changemakers that referenced this pull request Oct 18, 2023
Merge pull request frappe#133 from maniamartial/develop
@NagariaHussain
Copy link
Member

NagariaHussain commented Oct 20, 2023

Oh no, you didn't put the table in Case doctype? @maniamartial

And also no total amount field, but you are still trying to access it through code 🤦🏼

P.S. Got deployed to prod 🤣

@maniamartial
Copy link
Contributor Author

No, I did, maybe there is something am not doing right, but the table and total are there, I can access them on my end.
Md

@NagariaHussain
Copy link
Member

Maybe you didn't go in development mode, this changes were not there in case.json file.

@NagariaHussain
Copy link
Member

Fixed here: 3899606

@NagariaHussain
Copy link
Member

Also, we have a "Non Negative" property on field which you can use in order to make a currency/float/int field non-negative instead of writing the validation yourself:

CleanShot 2023-10-20 at 11 20 15@2x

@NagariaHussain
Copy link
Member

I didn't check it on my local, should have done that. Thanks for the contribution btw!

@maniamartial
Copy link
Contributor Author

Also, we have a "Non Negative" property on field which you can use in order to make a currency/float/int field non-negative instead of writing the validation yourself:

CleanShot 2023-10-20 at 11 20 15@2x

Thanks, I just realized that yesterday after watching your video.

@maniamartial
Copy link
Contributor Author

I didn't check it on my local, should have done that. Thanks for the contribution btw!

Sure, I am 2 months old in frappe and ERPNext dev, I hope to contribute more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants