Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gross Profit Report error #35942

Closed
nakul80 opened this issue Jun 30, 2023 · 5 comments · Fixed by #45548
Closed

Gross Profit Report error #35942

nakul80 opened this issue Jun 30, 2023 · 5 comments · Fixed by #45548

Comments

@nakul80
Copy link

nakul80 commented Jun 30, 2023

Information about bug

Using the Gross Profit report grouped by invoices shows incorrect gross profit average figure in the 'total' row. Also when changing the grouping to item code, it again gives another average figure which is also wrong.

Module

accounts

Version

ERPNext: v14.28.0 (HEAD)
Frappe Framework: v14.40.1 (HEAD)
India Compliance: v14.10.2 (HEAD)

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

@nakul80 nakul80 added the bug label Jun 30, 2023
@nakul80
Copy link
Author

nakul80 commented Jun 30, 2023

I think I figured out the error. In each grouping the figure changes except in monthly when it gives the right figure.

So, it takes the average of the gross profit% column rather than calculate using the totals. That has to be fixed as its a fundamental error in giving averages which have got to be on the totals (i.e. weighted).

@nakul80
Copy link
Author

nakul80 commented Jul 24, 2023

Hoping for a resolution to this fundamental issue.

@dvdl16
Copy link
Contributor

dvdl16 commented Oct 24, 2024

Can confirm, still an issue in v15

Frappe CRM: v1.19.0
South Africa Customisations: v0.1.6
ERPNext: v15.34.2
Frappe Framework: v15.40.3
Helpdesk: v0.10.0
Frappe HR: v15.28.3

@dvdl16
Copy link
Contributor

dvdl16 commented Oct 24, 2024

#33911

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.82.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants