Design Issues on Pricing Rule

[ruthra-kumar]

Pricing Rules where the discount / margin is applied on other item code / item group / brand is broken.

Broken Scenarios:

-	Apply On	Value	Apply Rule on Other	Value
1	Item Code	Item 1	Item Code	Item 2
2	Item Group	All Item Group	Item Group	All Item Group
3	Item Code/Group	any_value	Brand	any_value

On above cases, the discount is applied on the trigger item itself, either on item addition or upon save.

UOM Conversion on mixed condition

https://support.frappe.io/helpdesk/tickets/21803

#43166

Version

v14 and v15

References:
https://support.frappe.io/helpdesk/tickets/16804
https://support.frappe.io/helpdesk/tickets/17723
https://support.frappe.io/helpdesk/tickets/15810

[ruthra-kumar]

[1] Replication

Rules:

Discount.on.other.item.mp4

[ruthra-kumar]

Apply Discount on Other item lives only on Client-side

1. get_item_details() fetches and applies discount for the trigger item

   erpnext/erpnext/accounts/doctype/pricing_rule/pricing_rule.py

   Line 547 in 29a1fe8

   def apply_price_discount_rule(pricing_rule, item_details, args):

2. This is received on Client-side
3. Client-side removes discount of trigger item and applies it on target item