Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All references to "Notifier" should be replaced with references to "SafeNotifier" #84

Open
ewpratten opened this issue Oct 2, 2020 · 3 comments · May be fixed by #146
Open

All references to "Notifier" should be replaced with references to "SafeNotifier" #84

ewpratten opened this issue Oct 2, 2020 · 3 comments · May be fixed by #146
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest A temporary lable for good Hacktoberfest issues
Milestone
v2.2.0

Comments

@ewpratten
Copy link
Member

This requires the code implemented in #81

SafeNotifier is designed to directly replace Notifier. Just make sure everything compiles, and you can run the simulation correctly
@ewpratten ewpratten added enhancement New feature or request good first issue Good for newcomers hacktoberfest A temporary lable for good Hacktoberfest issues labels Oct 2, 2020
@ewpratten ewpratten added this to the v1.5.0 milestone Oct 2, 2020
@patrickjkennedy
Copy link

Hi @ewpratten can I work on this issue?

@ewpratten
Copy link
Member Author

Sure

@patrickjkennedy
Copy link

On further review, I don't think this particular issue is for me. Sorry for the trouble.

@ewpratten ewpratten modified the milestones: v2.1.0, v2.2.0 Oct 27, 2020
@ewpratten ewpratten linked a pull request Nov 4, 2020 that will close this issue
Open
@ewpratten ewpratten linked a pull request Nov 4, 2020 that will close this issue
Updated to SafeNotifier #146
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest A temporary lable for good Hacktoberfest issues
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Updated to SafeNotifier frc5024/lib5k
2 participants
@patrickjkennedy @ewpratten