From 59272f860dba517cc6c82656d4ba2393b970aa9c Mon Sep 17 00:00:00 2001 From: Oliver Eyton-Williams Date: Mon, 20 Nov 2023 15:40:01 +0100 Subject: [PATCH 1/2] chore: convert lint warnings to errors --- apps/frontend/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/frontend/package.json b/apps/frontend/package.json index cde273943..a21044ed3 100644 --- a/apps/frontend/package.json +++ b/apps/frontend/package.json @@ -6,7 +6,7 @@ "build": "next build", "dev": "next dev", "develop": "npm run dev", - "eslint": "next lint", + "eslint": "next lint --max-warnings 0", "format": "prettier --write .", "init": "shx cp -n sample.env .env", "prettier-check": "prettier --check .", From f266f35c8e5efdcc76988773f322c2d8e790cc75 Mon Sep 17 00:00:00 2001 From: Oliver Eyton-Williams Date: Mon, 20 Nov 2023 15:42:02 +0100 Subject: [PATCH 2/2] fix: provide all deps to useEffect --- apps/frontend/src/components/editor-drawer.jsx | 2 +- apps/frontend/src/components/post-form.jsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/frontend/src/components/editor-drawer.jsx b/apps/frontend/src/components/editor-drawer.jsx index 305d1fb01..26405d04a 100644 --- a/apps/frontend/src/components/editor-drawer.jsx +++ b/apps/frontend/src/components/editor-drawer.jsx @@ -78,7 +78,7 @@ const EditorDrawer = ({ setAuthorName(post.attributes.author.data.attributes.name); } - }, [post]); + }, [post, handlePostTagId]); const handleFileInputChange = (event) => { const file = event.target.files[0]; diff --git a/apps/frontend/src/components/post-form.jsx b/apps/frontend/src/components/post-form.jsx index 660ab1694..43850b3cc 100644 --- a/apps/frontend/src/components/post-form.jsx +++ b/apps/frontend/src/components/post-form.jsx @@ -69,10 +69,10 @@ const PostForm = ({ tags, user, authors, post }) => { setUnsavedChanges(true); }; - const handlePostTagId = (value) => { + const handlePostTagId = useCallback((value) => { setPostTagId([...value]); setUnsavedChanges(true); - }; + }, []); const handleAuthorChange = (author) => { setAuthor(author);