Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed CLI execution produces an empty "safe" document #214

Closed
apyrgio opened this issue Sep 22, 2022 · 0 comments
Closed

Failed CLI execution produces an empty "safe" document #214

apyrgio opened this issue Sep 22, 2022 · 0 comments
Assignees
@apyrgio
Labels
bug Something isn't working security

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Sep 22, 2022

Description

Running Dangerzone CLI on a Linux environment that does not have Podman properly configured, throws an error during document conversion. A side effect of this error is that it produces an empty *-safe.pdf document.

Steps to Reproduce

OS: Ubuntu 22.04
Release: 0.3.2

  • Ensure you have access to the Dangerzone CLI (run dangerzone-cli --help).
  • Make sure that podman images ls fails. You can temporarily move the /usr/bin/podman binary to somewhere else, for instance.
  • Have an example PDF document ready.
  • Run dangerzone-cli test.pdf within that container, where test.pdf is your example PDF.
  • List the contents of your directory. You should see a test-safe.pdf there.

Expected Behavior

Fail the execution without creating a safe document.
@apyrgio apyrgio added bug Something isn't working security labels Sep 22, 2022
@apyrgio apyrgio self-assigned this Sep 22, 2022
@apyrgio apyrgio mentioned this issue Nov 3, 2022
Merged
deeplow added a commit that referenced this issue Nov 3, 2022
@deeplow
FIXUP: use instead document alphanumerical IDs
f3c42b5 
Avoid using mutable state at the class level. Replace with
UUIDs and print a short version when referecing the document in stdout.

Fixes #214
deeplow added a commit that referenced this issue Nov 3, 2022
@deeplow
FIXUP: use instead document alphanumerical IDs
a887885 
Avoid using mutable state at the class level. Replace with
UUIDs and print a short version when referecing the document in stdout.

Fixes #214
apyrgio pushed a commit that referenced this issue Nov 8, 2022
@deeplow @apyrgio
FIXUP: use instead document alphanumerical IDs
8025e88 
Avoid using mutable state at the class level. Replace with
UUIDs and print a short version when referecing the document in stdout.

Fixes #214
deeplow added a commit to deeplow/dangerzone that referenced this issue Nov 10, 2022
@deeplow
FIXUP: use instead document alphanumerical IDs
d78637f 
Avoid using mutable state at the class level. Replace with
UUIDs and print a short version when referecing the document in stdout.

Fixes freedomofpress#214
deeplow added a commit to deeplow/dangerzone that referenced this issue Nov 10, 2022
@deeplow
FIXUP: use instead document alphanumerical IDs
5d5e073 
Avoid using mutable state at the class level. Replace with
UUIDs and print a short version when referecing the document in stdout.

Fixes freedomofpress#214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apyrgio apyrgio

Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apyrgio