Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PySide DeprecationWarning: exec_->exec #595

Closed
eloquence opened this issue Oct 12, 2023 · 1 comment · Fixed by #795
Closed

PySide DeprecationWarning: exec_->exec #595

eloquence opened this issue Oct 12, 2023 · 1 comment · Fixed by #795
Labels
good first issue Good for newcomers

Comments

@eloquence
Copy link
Member

Seen in QA with Ubuntu 22.04 target during tests:

/home/user/dangerzone/dangerzone/gui/main_window.py:208: DeprecationWarning: 'exec_' will be removed in the future. Use 'exec' instead. update_widget.exec_()

Wasn't able to find any actual deprecation timeline, just complaints about lack of documentation for this deprecation 🙃 https://bugreports.qt.io/browse/PYSIDE-1583
@eloquence eloquence mentioned this issue Oct 12, 2023
Closed
42 tasks
@deeplow
Copy link
Contributor

deeplow commented Oct 13, 2023

I was already aware, but had not yet created an issue. Thanks for opening it.

@deeplow deeplow added the good first issue Good for newcomers label Oct 19, 2023
naglis added a commit to naglis/dangerzone that referenced this issue May 1, 2024
@naglis
Use exec instead of exec_ for Qt dialogs
828c04d 
`exec_` is being deprecated in favor of `exec`.

Also use `launch()` helper method for `Dialog` subclasses.

Fixes freedomofpress#595
@naglis naglis mentioned this issue May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use exec instead of exec_ for Qt dialogs naglis/dangerzone
2 participants
@eloquence @deeplow