Use %F field code in .desktop entry
#798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, the `%u` field code results in multiple Dangerzone instances being launched when opening multiple documents with Dangerzone from e.g. Nautilus, as `%u` signifies that the application (in this case - Dangerzone) can only open a single file/URL at once. This changes the field code to `%F` as Dangerzone (now) supports converting multiple files at once. We use `%F` (multiple local files) instead of `%U` (multiple files and/or URLs) since Dangerzone does not support opening URLs. See also the Desktop Entry Specification [1] for more information on the field codes. Fixes freedomofpress#797 [1]: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html
apyrgio
force-pushed
the
797-desktop-field-code
branch
from
5748587
to
c3a570e
Compare
|
Merged, with an additional changelog item:
(I'll add proper attribution after prior to the release, sorry for missing that...) Also, I tested on macOS and it seems that it's bitten by a similar problem, albeit in a different way (see #800). If the fix is trivial, I'll try to include it in the 0.6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, the
%ufield code results in multiple Dangerzone instances being launched when opening multiple documents with Dangerzone from e.g. Nautilus, as%usignifies that the application (in this case - Dangerzone) can only open a single file/URL at once.This changes the field code to
%Fas Dangerzone (now) supports converting multiple files at once. We use%F(multiple local files) instead of%U(multiple files and/or URLs) since Dangerzone does not support opening URLs.See also the Desktop Entry Specification for more information on the field codes.
Fixes #797