Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog for 0.4.1 #366

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Update Changelog for 0.4.1 #366

merged 1 commit into from
Mar 27, 2023

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Mar 7, 2023

No description provided.

Copy link
Contributor

@deeplow deeplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changelog. I made some suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@deeplow
Copy link
Contributor

deeplow commented Mar 17, 2023

TGTM. But what do you think about us borrowing some inspiration from https://keepachangelog.com/en/1.0.0/

In specific:

  • add approx date to the version
  • group things into markdown subheadings instead of everything being prefixed by their category

Example:


## [1.1.1] - 2023-03-05

### Added

- Arabic translation (#444).
- v1.1 French translation.

They also group stuff into these categories, which seems reasonable:

Types of changes:
 -   Added for new features.
 -   Changed for changes in existing functionality.
 -   Deprecated for soon-to-be removed features.
 -   Removed for now removed features.
 -   Fixed for any bug fixes.
 -   Security in case of vulnerabilities.

@apyrgio
Copy link
Contributor Author

apyrgio commented Mar 21, 2023

Sorry, just saw this message. Actually, I use the "Keep A Changelog" format in my own projects, but I didn't want to enforce it on Dangerzone. If you like it as well, I can modify the new entry to follow this format.

@apyrgio
Copy link
Contributor Author

apyrgio commented Mar 22, 2023

I've updated the PR by changing the format to Keep A Changelog. Take a look!

@apyrgio apyrgio merged commit 8a7d52b into main Mar 27, 2023
@deeplow deeplow deleted the changelog-update branch May 11, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants