Add new file formats supported by PyMuPDF (epub, svg, bmp, pnm, bpm, ppm) #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had originally also added support for While |
deeplow
changed the title
apyrgio
approved these changes
Jan 31, 2024
Replaced for clarity over the fact that this conversion is in fact handled by PyMuPDF.
Partially fix for #660. Missing some files due to limitations [1]: - PSD - only available from PyMuPDF>=1.23.0 (qubes-fedora is lower) - TXT - only available from PyMuPDF>=1.23.7 (qubes-fedora is lower) - JXR - PyMuPDF was refusing to due to missing codec [1] - JPX - Generated test file was rejected by PyMuPDF [2] - FB2 - Most often cannot be detected by mime type alone [3] - CBZ - (idem) - XPS - (idem) - MOBI - (idem) - PAM - General version of other file format already included, so I decided not to include this extension [0] New test files were generated locally: - epub - generated with calibre's convert-ebook from another sample file - svg - generated with inkscape from a mix of a default template (hexagons) and a logo's PNG file - bmp, pnm, bpm, ppm - generated with ImageMagick's 'convert' from tests/test_docs/sample-png.png [0]: #660 (comment) [1]: #660 (comment) [2]: #660 (comment) [3]: #688
deeplow
force-pushed
the
660-pymupdf-formats
branch
from
39186c2
to
cd99122
Compare
deeplow
added a commit
to freedomofpress/dangerzone.rocks
that referenced
this pull request
Jan 31, 2024
Formats added to dangerzone version 0.6.0 in [1] [1]: freedomofpress/dangerzone#697
deeplow
added a commit
to freedomofpress/dangerzone.rocks
that referenced
this pull request
Feb 26, 2024
Formats added to dangerzone version 0.6.0 in [1] [1]: freedomofpress/dangerzone#697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(two commits on top of #627) just to get the Qubes support working.
Partially fixes for #660. Missing some files due to limitations 1:
decided not to include this extension 0
New test files were generated locally:
sample file
(hexagons) and a logo's PNG file
tests/test_docs/sample-png.png