Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for CSP violations #448

Open
conorsch opened this issue Apr 19, 2018 · 1 comment
Open

Write tests for CSP violations #448

conorsch opened this issue Apr 19, 2018 · 1 comment

Comments

@conorsch
Copy link
Contributor

Follow-up to #431. We are currently not testing for CSP violations in CI, and instead we require devs to validate that no CSP violations were introduced by running the local dev env during PR review and inspecting the console log. That's asking for trouble.

Let's wire up base Selenium tests to check for CSP violations. After a bit of reading, it appears it's currently impossible to inspect web console logs with Firefox as a Selenium driver, but with Chrome it may be possible.

@harrislapiroff
Copy link
Contributor

[Backlog pruning 5/10] We currently check if the CSP changes in infra tests. We don't scan for violations, we do use report-uri.com to monitor CSP issues, but aren't monitoring it very actively. This would be worth doing, but not urgently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants