Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance configuration flash message is unstyled #5220

Closed
rmol opened this issue May 1, 2020 · 0 comments · Fixed by #5223
Closed

Instance configuration flash message is unstyled #5220

rmol opened this issue May 1, 2020 · 0 comments · Fixed by #5223

Comments

@rmol
Copy link
Contributor

rmol commented May 1, 2020

Description

In #5046 we added flash messages confirming configuration changes, with the submission-preferences-success category. They appear properly styled when presented via the submission_preferences_saved_flash.html template, but they're also presented at the top of the page without the logic that styles them as successes or errors, so they're shown as plain text.

Steps to Reproduce

Start the dev server and navigate to the instance config, then toggle document uploads under Submission Preferences. You should see a page like this, with Preferences saved. at the top (plain) and bottom (styled):

image

Expected Behavior

That the flash message would appear in one place, or at least be styled the same wherever it appears.

Actual Behavior

The message at the top of the page is forlornly unadorned, while at the bottom it's miles of style.

Comments

In #5046 @eloquence pointed out that the message could easily be missed if it only appears at the bottom of the page, so we should probably just make sure that the same styling is applied to both occurrences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants