ipatool: Automate opening PR against supported branches #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
nicki-krizek
suggested changes
Aug 11, 2017
ipatool
Outdated
| "Failed to apply patches onto %s/%s. Manual backport is " | ||
| "needed. %s" % (ctx.config['remote'], bb, res.stderr) | ||
| )) | ||
| continue |
There was a problem hiding this comment.
A cleanup should be performed here.
ipatool
Outdated
| @@ -115,6 +116,7 @@ browser: firefox | |||
| # GitHub configuration | |||
| gh-token: "0123456789abcdef0123456789abcdef01234567" | |||
| gh-repo: "freeipa/freeipa" | |||
| gh-fork-remote: "ghfreeipa" | |||
There was a problem hiding this comment.
Please use "my-github" or something similar as an example. This can be confused as "github freeipa" (as in mirror of upstream pagure), which is not what we want here.
Add new option -B to pr-push. It allows to specify branch(es) that should also receive patches from PR. New PR is created against specified branch(es) to allow proper testing by CI. -B may be used multiple times.
nicki-krizek
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option -B to pr-push. It allows to specify branch(es) that should also
receive patches from PR. New PR is created against specified branch(es) to
allow proper testing by CI. -B may be used multiple times.