Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merging - issue? #4720

Open
flooie opened this issue Nov 21, 2024 · 3 comments
Open

Auto-merging - issue? #4720

flooie opened this issue Nov 21, 2024 · 3 comments

Comments

@flooie
Copy link
Contributor

flooie commented Nov 21, 2024

#4719

I was bumping juriscraper and set the PR to auto merge if all requirements were met. The automerge completed and then a random unrelated recap test failed. I'm not sure if this is a bug but I was under the impression that all tests needed to pass for auto merge to merge.

@mlissner
Copy link
Member

Are you sure that you didn't just hit the merge button? I feel like auto-merge disappeared for me while tests are running.

There's a RECAP issue that Eduardo is working on in the tests.

@flooie
Copy link
Contributor Author

flooie commented Nov 21, 2024

I guess that's as likely a scenario as there is. I was pretty sure I selected auto merge though.

@mlissner
Copy link
Member

Yeah, who knows. I don't know how/why automerge got changed. I haven't played with the branch protection settings, have you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants