Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Signing #13

Open
dex4er opened this issue Aug 15, 2024 · 5 comments
Open

Code Signing #13

dex4er opened this issue Aug 15, 2024 · 5 comments
Assignees
Labels
bug Something isn't working distribution Distribution of the binaries
Milestone

Comments

@dex4er
Copy link
Collaborator

dex4er commented Aug 15, 2024

Regarding https://www.electron.build/code-signing.html and https://www.electronforge.io/guides/code-signing/code-signing-macos#osxnotarize-options

We need certificates both for Windows and for MacOS.

We need to store them in GitHub secrets:

WIN_CSC_LINK and WIN_CSC_KEY_PASSWORD for Windows.
CSC_LINK and CSC_KEY_PASSWORD for Mac
also APPLEID, APPLEIDPASS, APPLETEAMID for Mac

Both here in https://github.com/freelensapp/freelens and https://github.com/freelensapp/freelens-nightly-builds

@robertobandini
Copy link
Contributor

Ok @dex4er I'll start today about Apple signing and then I'll continue with Windows.

@robertobandini
Copy link
Contributor

Actually I'm waiting an answer by Apple support to complete the process about enrolling to their developer program.
Meanwhile I'll check more about Windows signing.

@dex4er dex4er added this to the 0.1.1 milestone Oct 6, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 6, 2024

@robertobandini
Copy link
Contributor

More links about Windows:

It looks like Azure has service for €8.95/month that might be used directly from GitHub, however it is OV, not EV certificate.

https://codesigningsolution.com/the-differences-between-ev-and-ov-code-signing-certificates/

Thank you very much I'll check asap!
Apple has answered with a generic first email, maybe today or tomorrow I'll try again by app on iPhone, let's see.

@dex4er dex4er added the distribution Distribution of the binaries label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distribution Distribution of the binaries
Projects
Status: In Progress
Development

No branches or pull requests

2 participants