Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Snap package #38

Open
dex4er opened this issue Oct 16, 2024 · 2 comments
Open

Provide Snap package #38

dex4er opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
distribution Distribution of the binaries enhancement New feature or request

Comments

@dex4er
Copy link
Collaborator

dex4er commented Oct 16, 2024

We could add Ubuntu Snap packages and distribute them in https://snapcraft.io/

Our electron-builder unfortunately does not support base option so it builds by default for core18 base.

However we can build new Snap package based on existing DEB package (see https://www.electronjs.org/docs/latest/tutorial/snapcraft#using-an-existing-debian-package) then handling Snaps would be separate job in GHA.

We can build and publish separate packages for main repo and nightly.

@dex4er dex4er added the enhancement New feature or request label Oct 16, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 18, 2024

Snap must be built outside electron-builder as the used version uses deprecated base18. Also we need additional tweaking for the manifest. Our snapcraft.yaml is mostly created from the Snap package for VScode, including the electron-launch wrapper.

Because Lens uses $HOME/.kube and $HOME/.freelens we must to build it in classic mode: strict mode protects the content of the $HOME directory.

@dex4er dex4er added this to the 0.1.1 milestone Oct 18, 2024
@dex4er
Copy link
Collaborator Author

dex4er commented Oct 18, 2024

It makes less sens to distribute Snap packages outside https://snapcraft.io/ (similarly to Flatpaks outside https://flathub.org/). In that case, I'm going to remove Snaps from our releases as we need only DEB package.

@dex4er dex4er removed this from the 0.1.1 milestone Oct 18, 2024
@dex4er dex4er added the distribution Distribution of the binaries label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution Distribution of the binaries enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants