Shared tests for potential violations (stubbing non-existent/public methods, etc.)

test/acceptance/stubbing_any_instance_method.rb

@@ -0,0 +1,9 @@
+module StubbingAnyInstanceMethod
+  def method_owner
+    @method_owner ||= Class.new
+  end
+
+  def stubbee
+    method_owner.any_instance
+  end
+end

test/acceptance/stubbing_class_method.rb

@@ -0,0 +1,9 @@
+module StubbingClassMethod
+  def method_owner
+    stubbee.singleton_class
+  end
+
+  def stubbee
+    @stubbee ||= Class.new
+  end
+end

test/acceptance/stubbing_existing_method_is_allowed.rb

@@ -0,0 +1,23 @@
+require File.expand_path('../stubbing_public_method_is_allowed', __FILE__)
+
+module StubbingExistingMethodIsAllowed
+  include StubbingPublicMethodIsAllowed
+
+  def test_should_allow_stubbing_existing_protected_method
+    assert_allows_stubbing_existing_method(:protected)
+  end
+
+  def test_should_allow_stubbing_existing_private_method
+    assert_allows_stubbing_existing_method(:private)
+  end
+
+  def assert_allows_stubbing_existing_method(visibility)
+    method_owner.send(:define_method, :existing_method) {}
+    method_owner.send(visibility, :existing_method)
+    assert_allows_stubbing_method(:existing_method)
+  end
+
+  def configure_violation(config, treatment)
+    config.stubbing_non_existent_method = treatment
+  end
+end

test/acceptance/stubbing_instance_method.rb

@@ -0,0 +1,9 @@
+module StubbingInstanceMethod
+  def method_owner
+    stubbee.class
+  end
+
+  def stubbee
+    @stubbee ||= Class.new.new
+  end
+end

test/acceptance/stubbing_method_unnecessarily_test.rb

@@ -1,59 +1,23 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
-require 'mocha/configuration'
+require File.expand_path('../stubbing_with_potential_violation_is_checked', __FILE__)
 
 class StubbingMethodUnnecessarilyTest < Mocha::TestCase
-  include AcceptanceTest
+  include StubbingWithPotentialViolationIsCheckedAndAllowedByDefault
 
-  def setup
-    setup_acceptance_test
+  def configure_violation(config, treatment)
+    config.stubbing_method_unnecessarily = treatment
   end
 
-  def teardown
-    teardown_acceptance_test
+  def potential_violation
+    mock = mock('mock')
+    mock.stubs(:public_method)
   end
 
-  def test_should_allow_stubbing_method_unnecessarily
-    Mocha.configure { |c| c.stubbing_method_unnecessarily = :allow }
-    test_result = run_as_test do
-      mock = mock('mock')
-      mock.stubs(:public_method)
-    end
-    assert_passed(test_result)
-    assert !@logger.warnings.include?('stubbing method unnecessarily: #<Mock:mock>.public_method(any_parameters)')
-  end
-
-  def test_should_warn_when_stubbing_method_unnecessarily
-    Mocha.configure { |c| c.stubbing_method_unnecessarily = :warn }
-    test_result = run_as_test do
-      mock = mock('mock')
-      mock.stubs(:public_method)
-    end
-    assert_passed(test_result)
-    assert @logger.warnings.include?('stubbing method unnecessarily: #<Mock:mock>.public_method(any_parameters)')
-  end
-
-  def test_should_prevent_stubbing_method_unnecessarily
-    Mocha.configure { |c| c.stubbing_method_unnecessarily = :prevent }
-    test_result = run_as_test do
-      mock = mock('mock')
-      mock.stubs(:public_method)
-    end
-    assert_failed(test_result)
-    assert test_result.error_messages.include?('Mocha::StubbingError: stubbing method unnecessarily: #<Mock:mock>.public_method(any_parameters)')
-  end
-
-  def test_should_default_to_allow_stubbing_method_unnecessarily
-    test_result = run_as_test do
-      mock = mock('mock')
-      mock.stubs(:public_method)
-    end
-    assert_passed(test_result)
-    assert !@logger.warnings.include?('stubbing method unnecessarily: #<Mock:mock>.public_method(any_parameters)')
+  def message_on_violation
+    'stubbing method unnecessarily: #<Mock:mock>.public_method(any_parameters)'
   end
 
   def test_should_allow_stubbing_method_when_stubbed_method_is_invoked
-    Mocha.configure { |c| c.stubbing_method_unnecessarily = :prevent }
-    test_result = run_as_test do
+    test_result = run_test_with_check(:prevent) do
       mock = mock('mock')
       mock.stubs(:public_method)
       mock.public_method

test/acceptance/stubbing_nil_test.rb

@@ -1,58 +1,30 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
-require 'mocha/configuration'
+require File.expand_path('../stubbing_with_potential_violation_is_checked', __FILE__)
 
-class StubbingNilTest < Mocha::TestCase
-  include AcceptanceTest
+if RUBY_VERSION < '2.2.0'
+  class StubbingNilTest < Mocha::TestCase
+    include StubbingWithPotentialViolationIsChecked
 
-  def setup
-    setup_acceptance_test
-  end
-
-  def teardown
-    teardown_acceptance_test
-  end
-
-  if RUBY_VERSION < '2.2.0'
-    def test_should_allow_stubbing_method_on_nil
-      Mocha.configure { |c| c.stubbing_method_on_nil = :allow }
-      test_result = run_as_test do
-        nil.stubs(:stubbed_method)
-      end
-      assert_passed(test_result)
-      assert !@logger.warnings.include?('stubbing method on nil: nil.stubbed_method')
+    def configure_violation(config, treatment)
+      config.stubbing_method_on_nil = treatment
     end
 
-    def test_should_warn_on_stubbing_method_on_nil
-      Mocha.configure { |c| c.stubbing_method_on_nil = :warn }
-      test_result = run_as_test do
-        nil.stubs(:stubbed_method)
-      end
-      assert_passed(test_result)
-      assert @logger.warnings.include?('stubbing method on nil: nil.stubbed_method')
+    def potential_violation
+      nil.stubs(:stubbed_method)
     end
 
-    def test_should_prevent_stubbing_method_on_nil
-      Mocha.configure { |c| c.stubbing_method_on_nil = :prevent }
-      test_result = run_as_test do
-        nil.stubs(:stubbed_method)
-      end
-      assert_failed(test_result)
-      assert test_result.error_messages.include?('Mocha::StubbingError: stubbing method on nil: nil.stubbed_method')
+    def message_on_violation
+      'stubbing method on nil: nil.stubbed_method'
     end
 
-    def test_should_default_to_prevent_stubbing_method_on_non_mock_object
-      test_result = run_as_test do
-        nil.stubs(:stubbed_method)
-      end
+    def test_should_default_to_prevent_stubbing_method_on_nil
+      test_result = stub_with_potential_violation
       assert_failed(test_result)
-      assert test_result.error_messages.include?('Mocha::StubbingError: stubbing method on nil: nil.stubbed_method')
+      assert test_result.error_messages.include?("Mocha::StubbingError: #{message_on_violation}")
     end
 
     def test_should_allow_stubbing_method_on_non_nil_object
-      Mocha.configure { |c| c.stubbing_method_on_nil = :prevent }
-      object = Object.new
-      test_result = run_as_test do
-        object.stubs(:stubbed_method)
+      test_result = run_test_with_check(:prevent) do
+        Object.new.stubs(:stubbed_method)
       end
       assert_passed(test_result)
     end

test/acceptance/stubbing_non_existent_any_instance_method_test.rb

@@ -1,80 +1,15 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
-require 'mocha/configuration'
+require File.expand_path('../stubbing_non_existent_method_is_checked', __FILE__)
+require File.expand_path('../stubbing_existing_method_is_allowed', __FILE__)
+require File.expand_path('../stubbing_any_instance_method', __FILE__)
 
 class StubbingNonExistentAnyInstanceMethodTest < Mocha::TestCase
-  include AcceptanceTest
-
-  def setup
-    setup_acceptance_test
-  end
-
-  def teardown
-    teardown_acceptance_test
-  end
-
-  def test_should_allow_stubbing_non_existent_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :allow }
-    klass = Class.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:non_existent_method)
-    end
-    assert !@logger.warnings.include?("stubbing non-existent method: #{klass.any_instance.mocha_inspect}.non_existent_method")
-    assert_passed(test_result)
-  end
-
-  def test_should_warn_when_stubbing_non_existent_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :warn }
-    klass = Class.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:non_existent_method)
-    end
-    assert_passed(test_result)
-    assert @logger.warnings.include?("stubbing non-existent method: #{klass.any_instance.mocha_inspect}.non_existent_method")
-  end
-
-  def test_should_prevent_stubbing_non_existent_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    klass = Class.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:non_existent_method)
-    end
-    assert_failed(test_result)
-    assert test_result.error_messages.include?("Mocha::StubbingError: stubbing non-existent method: #{klass.any_instance.mocha_inspect}.non_existent_method")
-  end
-
-  def test_should_default_to_allow_stubbing_non_existent_any_instance_method
-    klass = Class.new
-    test_result = run_as_test do
-      klass.any_instance.stubs(:non_existent_method)
-    end
-    assert !@logger.warnings.include?("stubbing non-existent method: #{klass.any_instance.mocha_inspect}.non_existent_method")
-    assert_passed(test_result)
-  end
+  include StubbingNonExistentMethodIsChecked
+  include StubbingAnyInstanceMethod
+end
 
-  def test_should_allow_stubbing_existing_public_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    klass = Class.new do
-      def existing_public_method; end
-      public :existing_public_method
-    end
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_public_method)
-    end
-    assert_passed(test_result)
-  end
-
-  def test_should_allow_stubbing_method_to_which_any_instance_responds
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    klass = Class.new do
-      def respond_to?(method, _include_private = false)
-        (method == :method_to_which_instance_responds)
-      end
-    end
-    test_result = run_as_test do
-      klass.any_instance.stubs(:method_to_which_instance_responds)
-    end
-    assert_passed(test_result)
-  end
+class StubbingExistingAnyInstanceMethodIsAllowedTest < Mocha::TestCase
+  include StubbingExistingMethodIsAllowed
+  include StubbingAnyInstanceMethod
 
   def test_should_default_to_allowing_stubbing_method_if_responds_to_depends_on_calling_initialize
     klass = Class.new do
@@ -91,67 +26,20 @@ def respond_to?(method, _include_private = false)
     end
     assert_passed(test_result)
   end
+end
 
-  def test_should_allow_stubbing_existing_protected_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    klass = Class.new do
-      def existing_protected_method; end
-      protected :existing_protected_method
-    end
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_protected_method)
-    end
-    assert_passed(test_result)
-  end
-
-  def test_should_allow_stubbing_existing_private_any_instance_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    klass = Class.new do
-      def existing_private_method; end
-      private :existing_private_method
-    end
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_private_method)
-    end
-    assert_passed(test_result)
-  end
+class StubbingExistingAnyInstanceSuperclassMethodIsAllowedTest < Mocha::TestCase
+  include StubbingExistingMethodIsAllowed
 
-  def test_should_allow_stubbing_existing_public_any_instance_superclass_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    superklass = Class.new do
-      def existing_public_method; end
-      public :existing_public_method
-    end
-    klass = Class.new(superklass)
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_public_method)
-    end
-    assert_passed(test_result)
+  def method_owner
+    callee.superclass
   end
 
-  def test_should_allow_stubbing_existing_protected_any_instance_superclass_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    superklass = Class.new do
-      def existing_protected_method; end
-      protected :existing_protected_method
-    end
-    klass = Class.new(superklass)
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_protected_method)
-    end
-    assert_passed(test_result)
+  def stubbee
+    callee.any_instance
   end
 
-  def test_should_allow_stubbing_existing_private_any_instance_superclass_method
-    Mocha.configure { |c| c.stubbing_non_existent_method = :prevent }
-    superklass = Class.new do
-      def existing_private_method; end
-      private :existing_private_method
-    end
-    klass = Class.new(superklass)
-    test_result = run_as_test do
-      klass.any_instance.stubs(:existing_private_method)
-    end
-    assert_passed(test_result)
+  def callee
+    @callee ||= Class.new(Class.new)
   end
 end