-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce surface & size of Cardinality #481
Open
nitishr
wants to merge
8
commits into
freerange:main
Choose a base branch
from
nitishr:simplify-cardinality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4c992b9 - Browse repository at this point
Copy the full SHA 4c992b9View commit details -
make Cardinality#times similar to initializer
Since times now accepts a required and a maximum number of calls, it can replace at_{least,most}, reducing its API surface, which is internal anyway.
Configuration menu - View commit details
-
Copy full SHA for efebd73 - Browse repository at this point
Copy the full SHA efebd73View commit details -
replace Cardinality#times with Cardinality#update
... since times just delegated to update
Configuration menu - View commit details
-
Copy full SHA for aab35af - Browse repository at this point
Copy the full SHA aab35afView commit details -
Configuration menu - View commit details
-
Copy full SHA for b99931f - Browse repository at this point
Copy the full SHA b99931fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c59c53d - Browse repository at this point
Copy the full SHA c59c53dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e8c766 - Browse repository at this point
Copy the full SHA 3e8c766View commit details -
Refactor: rename Cardinality#count to times
This reverts commit 9d0d37a. 'times' expresses the responsibility of this method better, but had to be renamed earlier due to the introduction of a public method with the same name. That method is now gone, so we can revert to the original name.
Configuration menu - View commit details
-
Copy full SHA for 4c8984f - Browse repository at this point
Copy the full SHA 4c8984fView commit details
Commits on Mar 23, 2020
-
Expand documentation of cardinality methods.
By translating all other cardinality methods to the times method, we clarify both that all the other methods are merely syntactic sugar, and that they all set the lower and upper limits to the number of calls. Closes freerange#476
Configuration menu - View commit details
-
Copy full SHA for 41ad165 - Browse repository at this point
Copy the full SHA 41ad165View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.