Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce surface & size of Cardinality #481

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Mar 17, 2020

  1. Configuration menu
    Copy the full SHA
    4c992b9 View commit details
    Browse the repository at this point in the history
  2. make Cardinality#times similar to initializer

    Since times now accepts a required and a maximum number of calls, it can
    replace at_{least,most}, reducing its API surface, which is internal
    anyway.
    nitishr committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    efebd73 View commit details
    Browse the repository at this point in the history
  3. replace Cardinality#times with Cardinality#update

    ... since times just delegated to update
    nitishr committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    aab35af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b99931f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c59c53d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3e8c766 View commit details
    Browse the repository at this point in the history
  7. Refactor: rename Cardinality#count to times

    This reverts commit 9d0d37a. 'times'
    expresses the responsibility of this method better, but had to be
    renamed earlier due to the introduction of a public method with the same
    name. That method is now gone, so we can revert to the original name.
    nitishr committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    4c8984f View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Expand documentation of cardinality methods.

    By translating all other cardinality methods to the times method, we
    clarify both that all the other methods are merely syntactic sugar, and
    that they all set the lower and upper limits to the number of calls.
    
    Closes freerange#476
    nitishr committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    41ad165 View commit details
    Browse the repository at this point in the history