Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Async Backing #328

Closed
tonimateos opened this issue Feb 1, 2024 · 4 comments · Fixed by #853 or #865
Closed

Enable Async Backing #328

tonimateos opened this issue Feb 1, 2024 · 4 comments · Fixed by #853 or #865
Assignees
Labels
Grooming Needed Extra attention is needed

Comments

@tonimateos
Copy link
Contributor

tonimateos commented Feb 1, 2024

As a LAOS dev team I want to have asyn backing so the block production is faster and so that hardhat issues are solved

ACCEPTANCE:

  • Block production is 6 instead 12 seconds
  • Currently vesting of tokens continue to vest over the expected timeframe (not blockframe): the migration does not involve doubling the number of schedules. Instead, vesting of vested tokens.
  • Election duration, referenda, voting, also remains the same (timeframe, not blockframe)
@tonimateos tonimateos added this to LAOS Feb 1, 2024
@tonimateos tonimateos converted this from a draft issue Feb 1, 2024
@tonimateos tonimateos added the Sprint Candidate Proposed by PO for the very next sprint label Feb 1, 2024
@tonimateos tonimateos removed the Sprint Candidate Proposed by PO for the very next sprint label Feb 15, 2024
@tonimateos tonimateos removed the status in LAOS Oct 10, 2024
@tonimateos tonimateos changed the title Break down Async-backing into User Stories Enable Async Backing Oct 24, 2024
@tonimateos tonimateos linked a pull request Oct 24, 2024 that will close this issue
@tonimateos tonimateos added Grooming Needed Extra attention is needed Sprint Candidate Proposed by PO for the very next sprint labels Oct 24, 2024
@asiniscalchi asiniscalchi self-assigned this Oct 24, 2024
@asiniscalchi
Copy link
Member

it seems the way to go is a migration to set the new params of pallet vesting

@asiniscalchi
Copy link
Member

@magecnion magecnion self-assigned this Nov 14, 2024
@luispdm luispdm assigned luispdm and unassigned luispdm Nov 14, 2024
@asiniscalchi asiniscalchi self-assigned this Nov 15, 2024
@asiniscalchi
Copy link
Member

upgrading the node to the latest version ( 4916490 ) stops blocks prosuction:

10:21:26.975  INFO tokio-runtime-worker substrate: [Relaychain] 💤 Idle (9 peers), best: #3838540 (0x1037…2f20), finalized #3838535 (0x684c…1049), ⬇ 39.2kiB/s ⬆ 111.6kiB/s    
2024-11-15 10:21:27.012  INFO tokio-runtime-worker substrate: [Parachain] 💤 Idle (0 peers), best: #486602 (0xf055…3740), finalized #486599 (0x6df8…c698), ⬇ 0 ⬆ 0    
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0xbd132c48c67a746f60b29e69450eeec98c95a63ae45c53935c52706e48510f6a pov_hash=0x893c7aa499cfeb07a34d92278d54dc47735bb29a1e31e05d1d7feb032903325f traceID=251323643035537594147980293413350076105
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0x7a9f5b842834eda20cdac05d6438b9ad14c99f219f2a8c931390d4b559ff4f00 pov_hash=0xfb6da8e2a9e841f53fd380e63681f3c8b52af7320a85aa39050f700e50de3f5c traceID=162993246856101544997730959511879465389
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0xb196d38139360371f93b04bd1aa0747ac8fc2b389ef3ca0debe88e491c49e383 pov_hash=0x69f84c17b3bfe8ba77f2f9a1c83344600a993c97d73f7908c254ab7567dd6001 traceID=236056489609275612314428767536368612474
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0x204c58f21a517da0a8311b76090582785c63a4b13db2e8bc0a0b62e0dbb3cd11 pov_hash=0xe2f83c5081d8aff471d359572f827de4da63de6231ec4b2d37048c6855de8292 traceID=42931714459771531137809814160918545016
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0xf82557bcb6e6c1d648dfda763b4c48df4da9f235c8fe288ded837580e6326299 pov_hash=0x585023487bdbc1c386f022c0456cd4bbefa9562f896a78d9d39560f406eb1289 traceID=329842437459560235575003879036167145695
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0x39daac179e9ed1d6116c7b899522128c43283eb5cbafce22f9a8b4dde2d8bf08 pov_hash=0x8e861a6c052156b21a0a477fc06185ec8ee1817baa8c9e49ff4c0fc6d80eb9e9 traceID=76901406920690995848654632239266665100
2024-11-15 10:21:28.421  WARN tokio-runtime-worker parachain::collator-protocol: [Relaychain] Collation wasn't advertised to any validator. candidate_hash=0x60824397c84c0dfc57c6e63a02526e716080b3fbb1156a6b63422af516ba1d58 pov_hash=0x54c84b6a092e64c2bf88db2d0692bc5ba3b730f381332126e2ce59c2fdef6bde traceID=128282257133846382078536328706622910065
2024-11-15 10:21:30.417  INFO tokio-runtime-worker substrate: [Relaychain] 🏆 Imported #3838541 (0x1037…2f20 → 0xee49…80d6)

@asiniscalchi
Copy link
Member

with panics :

2024-11-15 10:16:31.918  INFO tokio-runtime-worker substrate: [Relaychain] 💤 Idle (9 peers), best: #3838492 (0x0db6…4f72), finalized #3838486 (0x8fb3…9421), ⬇ 218.1kiB/s ⬆ 127.1kiB/s    
2024-11-15 10:16:31.965  INFO tokio-runtime-worker substrate: [Parachain] 💤 Idle (0 peers), best: #486589 (0x8ba8…aeb6), finalized #486580 (0x0525…1e7c), ⬇ 0 ⬆ 0    
2024-11-15 10:16:36.919  INFO tokio-runtime-worker substrate: [Relaychain] 💤 Idle (9 peers), best: #3838492 (0x0db6…4f72), finalized #3838489 (0x2a29…9a75), ⬇ 38.1kiB/s ⬆ 66.1kiB/s    

====================

Version: 0.23.90-4916490dd3f

   0: sp_panic_handler::set::{{closure}}
   1: std::panicking::rust_panic_with_hook
   2: std::panicking::begin_panic_handler::{{closure}}
   3: std::sys_common::backtrace::__rust_end_short_backtrace
   4: rust_begin_unwind
   5: core::panicking::panic_fmt
   6: cumulus_pallet_parachain_system::<impl cumulus_pallet_parachain_system::pallet::Pallet<T>>::maybe_drop_included_ancestors
   7: frame_support::storage::transactional::with_transaction
   8: <cumulus_pallet_parachain_system::pallet::Call<T> as frame_support::traits::dispatch::UnfilteredDispatchable>::dispatch_bypass_filter::{{closure}}
   9: frame_support::dispatch_context::run_in_context
  10: <laos_runtime::RuntimeCall as frame_support::traits::dispatch::UnfilteredDispatchable>::dispatch_bypass_filter
  11: <laos_runtime::RuntimeCall as sp_runtime::traits::Dispatchable>::dispatch
  12: <fp_self_contained::checked_extrinsic::CheckedExtrinsic<AccountId,Call,Extra,SelfContainedSignedInfo> as sp_runtime::traits::Applyable>::apply
  13: frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::apply_extrinsic
  14: laos_runtime::api::dispatch
  15: environmental::using
  16: sc_executor::executor::WasmExecutor<H>::with_instance::{{closure}}
  17: <sc_executor::executor::NativeElseWasmExecutor<D> as sp_core::traits::CodeExecutor>::call
  18: sp_state_machine::execution::StateMachine<B,H,Exec>::execute
  19: <sc_service::client::call_executor::LocalCallExecutor<Block,B,E> as sc_client_api::call_executor::CallExecutor<Block>>::contextual_call
  20: <sc_service::client::client::Client<B,E,Block,RA> as sp_api::CallApiAt<Block>>::call_api_at
  21: <laos_runtime::RuntimeApiImpl<__SrApiBlock__,RuntimeApiImplCall> as sp_offchain::OffchainWorkerApi<__SrApiBlock__>>::__runtime_api_internal_call_api_at
  22: sp_block_builder::BlockBuilder::apply_extrinsic
  23: <laos_runtime::RuntimeApiImpl<Block,C> as sp_api::ApiExt<Block>>::execute_in_transaction
  24: fc_rpc::eth::pending::<impl fc_rpc::eth::Eth<B,C,P,CT,BE,A,CIDP,EC>>::pending_runtime_api::{{closure}}
  25: <fc_rpc::eth::Eth<B,C,P,CT,BE,A,CIDP,EC> as fc_rpc_core::eth::EthApiServer>::storage_at::{{closure}}
  26: jsonrpsee_core::server::rpc_module::RpcModule<Context>::register_async_method::{{closure}}::{{closure}}
  27: <sc_rpc_server::middleware::Middleware<S> as jsonrpsee_server::middleware::rpc::RpcServiceT>::call::{{closure}}
  28: jsonrpsee_server::server::handle_rpc_call::{{closure}}
  29: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  30: <tower_http::cors::ResponseFuture<F> as core::future::future::Future>::poll
  31: <jsonrpsee_server::middleware::http::proxy_get_request::ProxyGetRequest<S> as tower_service::Service<http::request::Request<hyper::body::body::Body>>>::call::{{closure}}
  32: <tower::util::either::Either<A,B> as core::future::future::Future>::poll
  33: sc_rpc_server::start_server::{{closure}}::{{closure}}::{{closure}}::{{closure}}::{{closure}}
  34: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch
  35: <hyper::server::server::new_svc::NewSvcTask<I,N,S,E,W> as core::future::future::Future>::poll
  36: tokio::runtime::task::core::Core<T,S>::poll
  37: tokio::runtime::task::raw::poll
  38: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
  39: tokio::runtime::scheduler::multi_thread::worker::Context::run
  40: tokio::runtime::context::set_scheduler
  41: tokio::runtime::context::runtime::enter_runtime
  42: tokio::runtime::scheduler::multi_thread::worker::run
  43: <tokio::runtime::blocking::task::BlockingTask<T> as core::future::future::Future>::poll
  44: tokio::runtime::task::core::Core<T,S>::poll
  45: tokio::runtime::task::harness::Harness<T,S>::poll
  46: std::sys_common::backtrace::__rust_begin_short_backtrace
  47: core::ops::function::FnOnce::call_once{{vtable.shim}}
  48: std::sys::pal::unix::thread::Thread::new::thread_start
  49: <unknown>
  50: <unknown>

2024-11-15 10:16:36.966  INFO tokio-runtime-worker substrate: [Parachain] 💤 Idle (0 peers), best: #486589 (0x8ba8…aeb6), finalized #486584 (0xf5fc…974a), ⬇ 0 ⬆ 0    

Thread 'tokio-runtime-worker' panicked at 'no space left for the block in the unincluded segment', /home/runner/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/8c8edac/cumulus/pallets/parachain-system/src/lib.rs:1337

This is a bug. Please report it at:

	https://github.com/freeverseio/laos/issues/new

2024-11-15 10:16:37.018  WARN tokio-runtime-worker wasm-runtime: Evicting failed runtime instance error=Runtime panicked: no space left for the block in the unincluded segment
2024-11-15 10:16:37.018  WARN tokio-runtime-worker sp_state_machine::overlayed_changes::changeset: 1 storage transactions are left open by the runtime. Those will be rolled back.    
2024-11-15 10:16:37.018  WARN tokio-runtime-worker sp_state_machine::overlayed_changes::changeset: 1 storage transactions are left open by the runtime. Those will be rolled back.    

@luispdm luispdm assigned luispdm and unassigned luispdm Nov 15, 2024
@tonimateos tonimateos removed the status in LAOS Dec 4, 2024
@tonimateos tonimateos removed the Sprint Candidate Proposed by PO for the very next sprint label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grooming Needed Extra attention is needed
Projects
Status: No status
5 participants