-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error client_secret is missing #44
Comments
Thanks for opening an issue. I posted a simple update (fregante/chrome-webstore-upload@93a0c3a) to test the logic in fregante/chrome-webstore-upload#46, but I thought that the change exclusively avoided checking for the existence of I didn't see that it was actually just a list of parameters, all of which were required: fregante/chrome-webstore-upload@93a0c3a I'll push 0.4.4 soon |
Since you're using that module through |
Changes in v2.0+ 👈 👈The secret is no longer required as long as you create a Chrome App. If you're seeing this message again, please follow the new guide to create new keys: https://github.com/fregante/chrome-webstore-upload/blob/main/How%20to%20generate%20Google%20API%20keys.md The existing keys should keep working for the foreseeable future though. |
Hey @fregante, I'm having some confusion. I'm trying to implement the github actions for chrome webstore but almost every action I came across asks for the client-secret. Only your cli tool seems to be following the latest updates. So I think I have to implement your cli tool in my workflow. Also let me know one thing that whenever I want to upload the extension the tool will be handling the access token expiration, correct me if I'm wrong. |
Yes that's the idea. I have not personally used this new key to publish real extensions, but another user reported it was still working months later I think. To ensure it works, you have to follow the latest guide because your old keys will still require the secret. I'm also about to release an action so maybe you won't have to 😉 |
So if I omit the client-secret it should still work as I'm using the latest guide? |
That workflow still uses v1, which needs the secret. You can replace v1 with v2 in your workflow and omit the secret (which does not exist in the new guide) |
What node version is that workflow running? v2 needs 14+ (noted here) |
Ohh thanks @AprilSylph , I'll check it with the node 14. |
Here an extension release I did today with the current version, without secret: |
I had a pretty old setup from 2016 and it broke as expected. However following the steps to re-create a new oauth app was super smooth. |
That wasn't expected 🤭 v2 was released as a breaking release as a precaution but the old code is supposedly still there and working, if the secret is still available. Anyway glad that the steps were working, 👌 they might be a little different if one is using a pre-existing Google API project |
Therefore I thought it is expected. From my observation and memories the application type |
I mean that after the update, your existing config should have kept working, as noted in the release notes: https://github.com/fregante/chrome-webstore-upload-cli/releases/tag/v2.0.0 But if you updated it and also delete the client_secret, then yes, the failure was expected. The suggestion was to keep the keys untouched |
This was not the case. I re-created and update the client_seccret after it was failing. |
Ouch. Thanks for the report |
Started to get this error after upgrading to 1.2.1 today:
Reverting back to 1.2.0 fixed the issue.
The text was updated successfully, but these errors were encountered: