-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
6 changed files
with
160 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,46 @@ | ||
| Please make sure that the issue subject starts with `<package-name>: ` | ||
| # Vorlage für einen Bugreport | ||
|
|
||
| # Issue template (remove lines from top till here) | ||
| English version below. | ||
|
|
||
| Maintainer: @\<github-user> (find it by checking history of the package Makefile) | ||
| Environment: (put here arch, model, OpenWrt version) | ||
| Bitte benenne deinen Bugreport in etwa so: `<package-name>: ` | ||
| Wenn du den Namen des Pakets nicht kennst, bei dem der Fehler auftritt, versuche bitte, | ||
| eine andere sinnvolle Überschrift zu finden. | ||
|
|
||
| Description: | ||
| Dein Bericht kann uns am meisten weiterhelfen, wenn du uns so viele Informationen | ||
| wie möglich gibst. Bitte gib uns mindestens diese Infos: | ||
|
|
||
| ``` | ||
| Formating code blocks by wrapping them with pairs of ``` | ||
| - Falter-Firmware Version | ||
| - Was hast du gemacht, unmittelbar bevor dir der Fehler aufgefallen ist? Wie können wir das nachstellen? | ||
| - Hast du auf deinem Router eine spezielle Konfiguration? (Irgendetwas, außer einfach nur den Einrichtungs-Wizard durchgehen?) | ||
|
|
||
| Bitte schreibe deinen Report auf Englisch oder Deutsch. Nimm gerne die Sprache, mit der du dich wohler fühlst. | ||
|
|
||
| ## Issue template | ||
|
|
||
| Please try to start the issue subject similar to `<package-name>: ` | ||
| If you don't know the package name, please make sure at least, that you use a | ||
| meaningful headline. | ||
|
|
||
| Your Issue is most useful to us, if you provide as much information as you | ||
| can. Please give at least these information: | ||
|
|
||
| - Falter-Firmware version | ||
| - What did you do, before you get known of the bug? How could we reproduce this? | ||
| - Did you configure something special on your router? (Anything other than just running the wizard?) | ||
|
|
||
| Feel free to either write your report in English or German. Whichever you feel more comfortable with. | ||
|
|
||
| ---------- Bitte entferne alles oberhalb dieser Zeilen -------- | ||
| ---------- Please remove everything above these lines --------- | ||
| --------------------- snip / schnipp -------------------------- | ||
|
|
||
| Falter Firmware Version: | ||
|
|
||
| Special config/Besondere Einstellungen: | ||
|
|
||
| Description/Beschreibung: | ||
|
|
||
| ```text | ||
| You can include code blocks by wrapping them with pairs of backticks (```) | ||
| Du kannst Codeblocks erstellen, indem du den Code mit Backticks (```) umschließt. | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,18 @@ | ||
| Maintainer: me / @\<github-user> (find it by checking history of the package Makefile) | ||
| Compile tested: (put here arch, model, OpenWrt version) | ||
| Run tested: (put here arch, model, OpenWrt version, tests done) | ||
| # Pull Request Vorlage / Template | ||
|
|
||
| Description: | ||
| Bitte die nicht-benutzte Sprachversion entfernen. | ||
| Please remove the Language version of this template, which you don't use. | ||
|
|
||
| ------------ schnipp /snip ------------ | ||
|
|
||
| Kompiliert Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an) | ||
| Läuft live Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an und wie du deine Änderungen getestet hast) | ||
|
|
||
| Beschreibung deiner Änderungen: | ||
|
|
||
| ---------- | ||
|
|
||
| Compile tested: (put here arch, model, Falter (_OpenWrt_) version) | ||
| Run tested: (put here arch, model, Falter (_OpenWrt_) version, tests done) | ||
|
|
||
| Description of your changes: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,50 @@ | ||
| --- | ||
| name: Test Formalities | ||
| on: [pull_request] # yamllint disable-line rule:truthy | ||
| name: lint | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Test Formalities | ||
| name: formalities | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| ref: "${{ github.event.pull_request.head.sha }}" | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Determine branch name | ||
| run: | | ||
| # shellcheck disable=SC2030 | ||
| BRANCH="${GITHUB_BASE_REF#refs/heads/}" | ||
| echo "Building for $BRANCH" | ||
| echo "BRANCH=$BRANCH" >> $GITHUB_ENV | ||
| echo "BRANCH=$BRANCH" >>"$GITHUB_ENV" | ||
| - name: Test formalities | ||
| run: | | ||
| # shellcheck disable=SC1091 | ||
| source .github/workflows/ci_helpers.sh | ||
| RET=0 | ||
| for commit in $(git rev-list HEAD ^origin/$BRANCH); do | ||
| info "=== Checking commit '$commit'" | ||
| if git show --format='%P' -s $commit | grep -qF ' '; then | ||
| err "Pull request should not include merge commits" | ||
| RET=1 | ||
| fi | ||
| subject="$(git show -s --format=%s $commit)" | ||
| if echo "$subject" | grep -q -e '^[0-9A-Za-z,+/_-]\+: ' -e '^Revert '; then | ||
| success "Commit subject line seems ok ($subject)" | ||
| else | ||
| err "Commit subject line MUST start with '<package name>: ' ($subject)" | ||
| RET=1 | ||
| fi | ||
| body="$(git show -s --format=%b $commit)" | ||
| sob="$(git show -s --format='Signed-off-by: %aN <%aE>' $commit)" | ||
| if echo "$body" | grep -qF "$sob"; then | ||
| success "Signed-off-by match author" | ||
| else | ||
| err "Signed-off-by is missing or doesn't match author (should be '$sob')" | ||
| RET=1 | ||
| fi | ||
| for commit in $(git rev-list HEAD ^origin/"$BRANCH"); do | ||
| info "=== Checking commit '$commit'" | ||
| if git show --format='%P' -s "$commit" | grep -qF ' '; then | ||
| err "Pull request should not include merge commits" | ||
| RET=1 | ||
| fi | ||
| subject="$(git show -s --format=%s "$commit")" | ||
| if echo "$subject" | grep -q -e '^[0-9A-Za-z,+/_-]\+: ' -e '^Revert '; then | ||
| success "Commit subject line seems ok ($subject)" | ||
| else | ||
| err "Commit subject line MUST start with '<package name>: ' ($subject)" | ||
| RET=1 | ||
| fi | ||
| done | ||
| exit $RET |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,32 @@ | ||
| --- | ||
| ################################# | ||
| ################################# | ||
| ## Super Linter GitHub Actions ## | ||
| ################################# | ||
| ################################# | ||
| name: Lint Code Base | ||
| name: lint | ||
|
|
||
| # | ||
| # Documentation: | ||
| # https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions | ||
| # | ||
|
|
||
| ############################# | ||
| # Start the job on all push # | ||
| ############################# | ||
| on: [push, pull_request] # yamllint disable-line rule:truthy | ||
|
|
||
| ############### | ||
| # Set the Job # | ||
| ############### | ||
| jobs: | ||
| build: | ||
| # Name the Job | ||
| name: Lint Code Base | ||
| # Set the agent to run on | ||
| name: lint | ||
| runs-on: ubuntu-latest | ||
|
|
||
| ############################################ | ||
| # Grant status permission for MULTI_STATUS # | ||
| ############################################ | ||
| permissions: | ||
| contents: read | ||
| packages: read | ||
| statuses: write | ||
|
|
||
| ################## | ||
| # Load all steps # | ||
| ################## | ||
| steps: | ||
| ########################## | ||
| # Checkout the code base # | ||
| ########################## | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| # Full git history is needed to get a proper | ||
| # list of changed files within `super-linter` | ||
| fetch-depth: 0 | ||
|
|
||
| ################################ | ||
| # Run Linter against code base # | ||
| ################################ | ||
| - name: Lint Code Base | ||
| uses: github/super-linter@v5 | ||
| env: | ||
| VALIDATE_ALL_CODEBASE: false | ||
| # Change to 'master' if your main branch differs | ||
| DEFAULT_BRANCH: master | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Run Lint | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y luarocks shellcheck | ||
| luarocks --local --tree $HOME/.luarocks install luacheck | ||
| make lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters