Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error spam when Rollout Service disabled #1906

Open
bernardo-bastos opened this issue Aug 26, 2024 · 1 comment
Open

Error spam when Rollout Service disabled #1906

bernardo-bastos opened this issue Aug 26, 2024 · 1 comment

Comments

@bernardo-bastos
Copy link
Collaborator

Hello Kuberpult Team,

Currently our kuberpult instance is not using the rollout service. We observed that our Datadog instance is accumulating several errors rpc error: code = Unimplemented desc = rollout service not configured.

After some investigation we believe that a check on StreamStatus() method is causing this error every time the UI is accessed and the rollout service disabled. Here are some links:
Due to this call: https://github.com/freiheit-com/kuberpult/blob/main/services/frontend-service/src/ui/App/index.tsx#L109
And this line: https://github.com/freiheit-com/kuberpult/blob/main/services/frontend-service/pkg/cmd/server.go#L701

Is this the expected behaviour?

@freiheit-com freiheit-com deleted a comment Aug 26, 2024
@freiheit-com freiheit-com deleted a comment Aug 26, 2024
@hannesg
Copy link
Member

hannesg commented Aug 26, 2024

Hi @bernardo-bastos,

I did this mainly for easier backward compatibility. We have the rollout service enabled in most projects as it provides valuable features. However, I would be fine with handling this case without the error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants