Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Private graph] research extrinsic overhead for using signed extensions #1095

Closed
p5150j opened this issue Feb 15, 2023 · 1 comment
Closed

[Private graph] research extrinsic overhead for using signed extensions #1095

p5150j opened this issue Feb 15, 2023 · 1 comment
Assignees
@JoeCap08055
Labels
Private Graph Private Graph Spike research / spike

Comments

@p5150j
Copy link
Collaborator

p5150j commented Feb 15, 2023 •
edited by aramikm
Loading

[Paused]
Research extrinsic overhead for using signed extensions.

We would like to use some of the checks in signed extensions to remove invalid requests to go inside the block too early

  • race condition
  • schema related checks
  • calculate the wight from signed extension

AC:

  • calculate extrinsic overhead without changes
  • new signed extension with PG and pull checks in
  • recalculate extrinsic overhead with changes
@p5150j p5150j added Private Graph Private Graph Spike research / spike labels Feb 15, 2023
JoeCap08055 added a commit that referenced this issue Feb 27, 2023
@JoeCap08055
feat(overhead-benchmarks): add support for overhead benchmark #1095
0a20d6e
JoeCap08055 added a commit that referenced this issue Feb 27, 2023
@JoeCap08055
feat(overhead-benchmarks): alternate approach to overhead benchmarking …
9b0a145 
…#1095
JoeCap08055 added a commit that referenced this issue Feb 28, 2023
@JoeCap08055
feat(overhead-benchmarks): overhead benchmarking WIP #1095
9638087
JoeCap08055 added a commit that referenced this issue Feb 28, 2023
@JoeCap08055
feat(overhead-benchmarks): overhead benchmarking WIP #1095
508552d
JoeCap08055 added a commit that referenced this issue Mar 1, 2023
@JoeCap08055
feat(overhead-benchmarks): overhead benchmarking #1095
e6a5475
JoeCap08055 added a commit that referenced this issue Mar 2, 2023
@JoeCap08055
feat(overhead-benchmarks): sync from private-graph-main #1095
e7f9da6
JoeCap08055 added a commit that referenced this issue Mar 2, 2023
@JoeCap08055
feat(overhead-benchmarks): clean up and enhance benchmark script #1095
7b86562
JoeCap08055 added a commit that referenced this issue Mar 2, 2023
@JoeCap08055
feat(overhead-benchmarks): temporary Jenkinsfile mod to run only over…
192fcbd 
…head benchmarks in CI #1095
JoeCap08055 added a commit that referenced this issue Mar 2, 2023
@JoeCap08055
feat(overhead-benchmarks): revert temporary Jenkinsfile mod #1095
6de2e50
@p5150j p5150j closed this as completed Mar 6, 2023
@p5150j p5150j reopened this Mar 6, 2023
JoeCap08055 added a commit that referenced this issue Mar 7, 2023
@JoeCap08055
feat(stateful-signed-extension): add SignedExtension for stateful-sto…
5bc293c 
…rage pallet #

#1095
@JoeCap08055 JoeCap08055 mentioned this issue Mar 7, 2023
Closed
6 tasks
JoeCap08055 added a commit that referenced this issue Mar 7, 2023
@JoeCap08055
feat(stateful-signed-extension): temporary change to run specific ben…
ee2f33c 
…chmarks #1095
JoeCap08055 added a commit that referenced this issue Mar 8, 2023
@JoeCap08055
feat(stateful-signed-extension): update tags in SignedExtension #1095
85b3080
JoeCap08055 added a commit that referenced this issue Mar 8, 2023
@JoeCap08055
Revert "feat(stateful-signed-extension): temporary change to run spec…
c627d8b 
…ific benchmarks #1095"

This reverts commit ee2f33c.
JoeCap08055 added a commit that referenced this issue Mar 8, 2023
@JoeCap08055
feat(stateful-signed-extension): fix tests #1095
72559e5
JoeCap08055 added a commit that referenced this issue Mar 8, 2023
@JoeCap08055
feat(stateful-signed-extension): change tx tag in signed ext. to tuple …
2983daf 
…#1095
JoeCap08055 added a commit that referenced this issue Mar 11, 2023
@JoeCap08055
feat(stateful-signed-extension): add nonce to page content hash for r…
5250e4a 
…eplay prevention #1095
@JoeCap08055 JoeCap08055 mentioned this issue Mar 11, 2023
Merged
aramikm pushed a commit that referenced this issue Mar 13, 2023
@JoeCap08055 @aramikm
feat(stateful-signed-extension): add nonce to page content hash for r…
b98e3af 
…eplay prevention #1095
@aramikm
Copy link
Collaborator

aramikm commented Mar 22, 2023

This is currently paused until we merge capacity due to some common use-cases

@JoeCap08055 JoeCap08055 linked a pull request Mar 28, 2023 that will close this issue
feat(stateful-signed-extension): add SignedExtension for stateful-sto… #1194
Closed
6 tasks
JoeCap08055 added a commit that referenced this issue Mar 28, 2023
@JoeCap08055
feat(#1095): new branch from main and merge old stateful-storage-sign…
7bfa639 
…ed-extension branch in #1095
JoeCap08055 added a commit that referenced this issue Mar 29, 2023
@JoeCap08055
feat(#1095): update error reporting #1095
5b880d3
@JoeCap08055 JoeCap08055 mentioned this issue Mar 29, 2023
Closed
6 tasks
@p5150j p5150j closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeCap08055 JoeCap08055

Labels
Private Graph Private Graph Spike research / spike
Projects
None yet
Milestone
No milestone
3 participants
@p5150j @aramikm @JoeCap08055