Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Split Runtime and Node #2043

Open
1 task done
wilwade opened this issue Jun 25, 2024 · 1 comment
Open
1 task done

[Feature]: Split Runtime and Node #2043

wilwade opened this issue Jun 25, 2024 · 1 comment

Comments

@wilwade
Copy link
Collaborator

wilwade commented Jun 25, 2024

Feature Description

Details

It is now possible to separate out the repositories for the node vs the runtime code of the chain.

Goal

To have a clean separation between the node and the runtime

A/C (Repo Split Version)

(Note names are WIP)

  • Two repos, both with the history up to now
  • frequency-chain/runtimes (or should this still be the frequency repo?): Contains the Mainnet and Testnet runtimes
    • Produces wasm and runtime related artifacts only
  • frequency-chain/node: Contains the custom node code for frequency
    • Produces the Docker images and node binaries

Open Questions

  • How do we handle local development runtime builds? aka what does make start do in what repo?
  • Do we need to separate repos or just one repo with separate folders?
  • Testing e2e setup goes in which repo or both?
  • Where does api-augment live?

Related

Searched for Related Issues

  • I have done a search for related issues and either found none, or noted them
@wilwade wilwade added the discussion Topic for Discussion at a Community Call label Jun 25, 2024
@wilwade
Copy link
Collaborator Author

wilwade commented Jul 18, 2024

Notes from the 2024-07-18 Community Call

  • Where does code that is common between the runtime and the node go?
    • Argument for mono-repo
    • Any additional interactions between these?
    • How much can we just get rid of the overlap? A lot of common isn't used on both sides
  • Following the pattern of the larger community
    • Argument for at least doing it, and maybe separate repos
  • What is our current list of custom node features?
    • TODO: @wilwade to add a list
    • Reverse index of MSAs to Keys
    • Custom RPCs (Some Custom RPCs can move to Runtime APIs. Make sure to note which ones could move to Runtime APIs easily/hard/etc...)
      • Nonce
    • Note that there has been some talk of more custom options with Omni-Node

Polled Consensus:

  • Is separating out the node from the runtime a good idea?
    • Strong YES
  • One repo or two?
    • Start with one, consider moving to two later separately

@wilwade wilwade removed the discussion Topic for Discussion at a Community Call label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants