Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies for api augment and e2e tests #1965

Merged
merged 5 commits into from
May 9, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented May 8, 2024

Goal

The goal of this PR is to get Api Augment to Polkadotjs v11+

Discussion

  • Update eslint to flat config files and ready for v9
  • Polkadotjs/api v11
  • Node to v20.12.2
  • Other small package updates

- Update eslint to flat config files and ready for v9
- Polkadotjs/api v11
- Node to v20.12.2
- Other small package updates
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to the new flat config eslint style

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

@@ -23,46 +24,46 @@ import { u8aWrapBytes } from '@polkadot/util';
import type { Call } from '@polkadot/types/interfaces/runtime';
import { hasRelayChain } from './env';

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting below

@@ -1,3 +1,4 @@
import '@frequency-chain/api-augment';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this was working without this before, but it has to be called before polkadot/api

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to keep it as same as possible

"format": "tsc --noEmit --pretty && eslint --fix \"**/*.ts\"",
"lint": "tsc --noEmit --pretty && eslint \"**/*.ts\""
"format": "tsc --noEmit --pretty && prettier --write . && eslint --fix",
"lint": "tsc --noEmit --pretty && prettier --check . && eslint"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint doesn't do the prettier side anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automatic formatting and linting

},
"devDependencies": {
"@polkadot/typegen": "10.12.4",
Copy link
Collaborator Author

@wilwade wilwade May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this had this dependency. It isn't used in the e2e side. Likely just a copy paste from augment.

@wilwade wilwade marked this pull request as ready for review May 8, 2024 20:59
@wilwade wilwade requested review from a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team May 8, 2024 21:04
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through all the changes, looks good.
    lgtm

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through the changes
  • Checked out branch & ran make e2e-tests, which passed.
    Good to go pending CI passing :)
    :shipit:

@wilwade wilwade merged commit 80a5407 into main May 9, 2024
28 checks passed
@wilwade wilwade deleted the chore/update-api-augment-dependencies branch May 9, 2024 14:03
shannonwells pushed a commit that referenced this pull request May 16, 2024
# Goal
The goal of this PR is to get Api Augment to Polkadotjs v11+


# Discussion
- Update eslint to flat config files and ready for v9
- Polkadotjs/api v11
- Node to v20.12.2
- Other small package updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants