-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JS dependencies for api augment and e2e tests #1965
Conversation
- Update eslint to flat config files and ready for v9 - Polkadotjs/api v11 - Node to v20.12.2 - Other small package updates
e2e/eslint.config.mjs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to the new flat config eslint style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
@@ -23,46 +24,46 @@ import { u8aWrapBytes } from '@polkadot/util'; | |||
import type { Call } from '@polkadot/types/interfaces/runtime'; | |||
import { hasRelayChain } from './env'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting below
@@ -1,3 +1,4 @@ | |||
import '@frequency-chain/api-augment'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this was working without this before, but it has to be called before polkadot/api
e2e/scaffolding/helpers.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/eslint.config.mjs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to keep it as same as possible
"format": "tsc --noEmit --pretty && eslint --fix \"**/*.ts\"", | ||
"lint": "tsc --noEmit --pretty && eslint \"**/*.ts\"" | ||
"format": "tsc --noEmit --pretty && prettier --write . && eslint --fix", | ||
"lint": "tsc --noEmit --pretty && prettier --check . && eslint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint doesn't do the prettier side anymore
js/api-augment/scripts/package.cjs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/test/index.test.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/tsconfig.cjs.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/tsconfig.eslint.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/tsconfig.esm.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/tsconfig.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
js/api-augment/tsconfig.types.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All automatic formatting and linting
}, | ||
"devDependencies": { | ||
"@polkadot/typegen": "10.12.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this had this dependency. It isn't used in the e2e side. Likely just a copy paste from augment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through all the changes, looks good.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through the changes
- Checked out branch & ran
make e2e-tests
, which passed.
Good to go pending CI passing :)
# Goal The goal of this PR is to get Api Augment to Polkadotjs v11+ # Discussion - Update eslint to flat config files and ready for v9 - Polkadotjs/api v11 - Node to v20.12.2 - Other small package updates
Goal
The goal of this PR is to get Api Augment to Polkadotjs v11+
Discussion