Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Dev Genesis Starting Schema #2160

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Set Dev Genesis Starting Schema #2160

merged 6 commits into from
Sep 25, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Sep 23, 2024 •
edited
Loading

Goal

The goal of this PR is to update the development genesis to start at 16_000 so that schemas from mainnet do not collide.

Closes #2126

Discussion

  • Update Genesis schemas from mainnet
  • Updates to the state copy tool
  • Set the Genesis value of CurrentSchemaIdentifierMaximum to 16_000

Checklist

  • Unit Tests added?
  • Spec version incremented?

Expected:

  • New schemas post merge should deploy to 16_000+
  • See these (in addition to other) mainnet schemas on dev. (State queries should match mainnet)
    dsnp.update: 19
    dsnp.reply: 18
    dsnp.tombstone: 16
    dsnp.broadcast: 17

@wilwade wilwade requested review from a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team September 23, 2024 20:51
wilwade
wilwade commented Sep 23, 2024
View reviewed changes
resources/genesis-schemas.json Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated via make genesis-schemas

wilwade
wilwade commented Sep 23, 2024
View reviewed changes
tools/state-copy/README.md
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up the state-copy tool as it is now used for copying the schemas from mainnet to testnet.

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pallets/schemas/src/lib.rs 82.31% <100.00%> (+0.05%) ⬆️

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Sep 23, 2024
@wilwade wilwade enabled auto-merge (squash) September 23, 2024 22:09
shannonwells
shannonwells reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make start without the script to verify the genesis, I ran the script to fetch the state from testnet to localhost and that also worked.

I just have 2 nitpicks, the rename and the correction to the doc

tools/state-copy/remove.mjs Outdated Show resolved Hide resolved
tools/state-copy/README.md Outdated Show resolved Hide resolved
tools/state-copy/schemas.mjs Outdated Show resolved Hide resolved
@wilwade @shannonwells
Apply suggestions from code review
4104ebe 
Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com>
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 24, 2024
shannonwells
shannonwells approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, I don't think it's worth a respin just for the comment/instructions change unless you want to

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Sep 24, 2024
saraswatpuneet
saraswatpuneet approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read through files, looks good

mattheworris
mattheworris approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through code
  • Ran tests (All passing)
    🚢 it!

@wilwade wilwade merged commit f29d8f4 into main Sep 25, 2024
27 checks passed
@wilwade wilwade deleted the feature/set-starting-schema-id branch September 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@mattheworris mattheworris mattheworris approved these changes

@shannonwells shannonwells shannonwells approved these changes

@enddynayn enddynayn Awaiting requested review from enddynayn enddynayn was automatically assigned from frequency-chain/pr-reviewers

@aramikm aramikm Awaiting requested review from aramikm aramikm was automatically assigned from frequency-chain/pr-reviewers

@claireolmstead claireolmstead Awaiting requested review from claireolmstead claireolmstead was automatically assigned from frequency-chain/pr-reviewers

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055 JoeCap08055 was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force Testnet on Paseo Schemas to Match Mainnet
5 participants
@wilwade @shannonwells @mattheworris @saraswatpuneet @JoeCap08055