Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the whole Dispatch object when reporting dispatch updates #55

Open
llucax opened this issue Sep 24, 2024 · 0 comments
Open

Pass the whole Dispatch object when reporting dispatch updates #55

llucax opened this issue Sep 24, 2024 · 0 comments
Labels
scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users

Comments

@llucax
Copy link
Contributor

llucax commented Sep 24, 2024

We are now using a DispatchUpdate object that only has the selector (named as components), dry_run and payload (maybe named inputs or options).

It might be better to send an actual Dispatch object, in case the user needs to access more information about the particular dispatch that triggered the update.

We still need to account for potential "merges", like for now dispatches with the same type as merged is if they were one big virtual dispatch. For example, if we are merging all dispatches with different IDs but the same type, and we have id=1 start=10:00 end=11:00 and id=2 start=11:00 end=None, that would be merged into a dispatch with start=10:00 and end=None).

Related to:

If we do no merging by default, then we can just return the Dispatch object and other merge functions can have their own update types that make sense for that particular merge. For example, if we are merging by selector as well as type, we might not want to have the selector in the DispatchUpdate as it is redundant.

Originally posted by @llucax in #54 (comment)

@llucax llucax added scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

1 participant