Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split FormulaGenerator.generate() to generate() and generate_3_phase(). #1055

Open
llucax opened this issue Aug 29, 2024 · 0 comments
Open

Split FormulaGenerator.generate() to generate() and generate_3_phase(). #1055

llucax opened this issue Aug 29, 2024 · 0 comments
Labels
part:data-pipeline Affects the data pipeline type:enhancement New feature or enhancement visitble to users
Milestone
Untriaged

Comments

@llucax
Copy link
Contributor

llucax commented Aug 29, 2024

The typing of generate() is not very convenient as usually a formula produce either a Sample or a Sample3Phase but not both.

@shsms suggested to have generate and generate_3_phase, and different formulas implement different functions.

Originally posted by @shsms in #1037 (comment)
@llucax llucax added this to the Untriaged milestone Aug 29, 2024
@llucax llucax added type:enhancement New feature or enhancement visitble to users part:data-pipeline Affects the data pipeline labels Aug 29, 2024
@llucax llucax mentioned this issue Aug 29, 2024
Merged
@llucax llucax changed the title Split FormulaBuilder.generate() to generate() and generate_3_phase(). Split FormulaGenerator.generate() to generate() and generate_3_phase(). Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:data-pipeline Affects the data pipeline type:enhancement New feature or enhancement visitble to users
Projects
Python SDK Roadmap
Status: To do
Milestone
Untriaged
Development

No branches or pull requests
1 participant
@llucax