Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribing from metrics in the data pipeline #1071

Open
shsms opened this issue Sep 5, 2024 · 1 comment
Open

Unsubscribing from metrics in the data pipeline #1071

shsms opened this issue Sep 5, 2024 · 1 comment
Labels
part:data-pipeline Affects the data pipeline type:enhancement New feature or enhancement visitble to users

Comments

@shsms
Copy link
Contributor

shsms commented Sep 5, 2024

What's needed?

Currently it is only possible to subscribe to metrics from the DataSourcingActor and ResamplingActor, but impossible to unsubscribe. This needs to be supported.

Proposed solution

Track the number of subscriptions received and the number of unsubscribe requests received in both the actors. As soon all subscriptions have received an unsubscribe, the streams can be stopped in these actors. They would also have to unsubscribe from their upstream.

The microgrid client might also have to add support.

We would also have to ensure that the unsubscribe requests are from the original subscribers, and not from once subscriber sending an unsubscribe request twice.

Use cases

Adding this support would be useful, now that we use fallback components, and streams for fallback components can be stopped as soon as the primary components are streaming data again.

If not the CPU overhead could just keep growing over time especially in large locations, as more and more components have intermittent outages.

Alternatives and workarounds

No response

Additional context

No response

@shsms shsms added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Sep 5, 2024
@shsms
Copy link
Contributor Author

shsms commented Sep 5, 2024

Related to #1045

@shsms shsms added part:data-pipeline Affects the data pipeline and removed part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:data-pipeline Affects the data pipeline type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

1 participant