Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getitem magic in moving window #676

Closed
cwasicki opened this issue Sep 14, 2023 · 1 comment
Closed

Fix getitem magic in moving window #676

cwasicki opened this issue Sep 14, 2023 · 1 comment
Assignees
Labels
part:data-pipeline Affects the data pipeline priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working
Milestone

Comments

@cwasicki
Copy link
Collaborator

cwasicki commented Sep 14, 2023

What happened?

The current getitem magic in the moving window has several bugs, e.g.

What did you expect instead?

Full list-type indexing support (without steps) of the getitem magic.

Affected version(s)

No response

Affected part(s)

Data pipeline (part:data-pipeline)

Extra information

With #672 and using the window method from #668 in the case of slices it should be possible to fix these problems.

@cwasicki cwasicki added priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working labels Sep 14, 2023
@keywordlabeler keywordlabeler bot added the part:data-pipeline Affects the data pipeline label Sep 14, 2023
@cwasicki cwasicki added this to the v1.0.0-rc2 milestone Sep 14, 2023
@cwasicki cwasicki self-assigned this Sep 14, 2023
@cwasicki
Copy link
Collaborator Author

cwasicki commented Oct 2, 2023

For slices a TypeError is raised for a call of window[-1:] instead of this test case

This is equivalent to this test case:


and thereby fixed in current v0.x.x branch.

Also #672 has been merged into v0.x.x.

Therefore closing this issue.

@cwasicki cwasicki closed this as completed Oct 2, 2023
@github-project-automation github-project-automation bot moved this from To do to Done in Python SDK Roadmap Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:data-pipeline Affects the data pipeline priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working
Projects
Development

No branches or pull requests

1 participant