New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Check all conditionals for on-hit effects and exclude from combat stats #410

Open

fribbels opened this issue Jun 6, 2024 · 0 comments

Owner

fribbels commented Jun 6, 2024

Motivation

Some buff effects are not actually combat stats, but rather trigger only on hit without adding to the character's stats. For example, crit rate buffs from Wastelander. This means our set activation might be incorrect in cases like Rutilant/etc

Goal

Revisit all the conditionals, figure out which ones are on-hit effects and which ones are not, then patch the damage calculations to account for this disparity. Potentially introduce a third view for Basic / Combat / On-Hit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment